NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.13] gh-117482: Fix Builtin Types Slot Wrappers (gh-121602)#121630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericsnowcurrently merged 1 commit intopython:3.13frommiss-islington:backport-5250a03-3.13

Jul 11, 2024

Merged

[3.13] gh-117482: Fix Builtin Types Slot Wrappers (gh-121602)#121630

ericsnowcurrently merged 1 commit intopython:3.13frommiss-islington:backport-5250a03-3.13

Jul 11, 2024

Conversation

Copy link

Contributor

miss-islington commentedJul 11, 2024•
edited by bedevere-appbot
Loading

When builtin static types are initialized for a subinterpreter, various "tp" slots have already been inherited (for the main interpreter). This was interfering with the logic in add_operators() (in Objects/typeobject.c), causing a wrapper to get created when it shouldn't. This change fixes that by preserving the original data from the static type struct and checking that.
(cherry picked from commit5250a03)

Co-authored-by: Eric Snowericsnowcurrently@gmail.com

Issue:Weirdint.__str__ behaviour inside sub-interpreters #117482

pythongh-117482: Fix Builtin Types Slot Wrappers (pythongh-121602)

4b5e638

When builtin static types are initialized for a subinterpreter, various "tp" slots have already been inherited (for the main interpreter).  This was interfering with the logic in add_operators() (in Objects/typeobject.c), causing a wrapper to get created when it shouldn't.  This change fixes that by preserving the original data from the static type struct and checking that.(cherry picked from commit5250a03)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>