Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-121554: remove unnecessary internal functions in compile.c#121555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 8 commits intopython:mainfromiritkatriel:opcode_has
Jul 10, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJul 9, 2024•
edited by bedevere-appbot
Loading

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider splitting this PR in two:

  1. the build change
  2. the C API change

@erlend-aasland
Copy link
Contributor

I wonder if_PyImport_Inittab also needs to change now.

@iritkatriel
Copy link
MemberAuthor

I wonder if_PyImport_Inittab also needs to change now.

It has both:

  {"_opcode", PyInit__opcode},   {"_operator", PyInit__operator},

so it seems to cover both linkage methods.

@iritkatriel
Copy link
MemberAuthor

Consider splitting this PR in two:

  1. the build change
  2. the C API change

If we need to revert the build change then we also need to revert the code change. Might be easier in one PR.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

Yeah, but_opcode currently comes after the second freeze marker, FWIW.

@iritkatriel
Copy link
MemberAuthor

Yeah, but_opcode currently comes after the second freeze marker, FWIW.

What does that mean?

@erlend-aasland
Copy link
Contributor

Yeah, but_opcode currently comes after the second freeze marker, FWIW.

What does that mean?

Ah, forget it; I was looking at a generated file. Sorry 'bout the noise.

@iritkatriel
Copy link
MemberAuthor

@erlend-aasland Thanks for your help. Tests pass now, are you happy to approve this?

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@iritkatrieliritkatriel merged commit6557af6 intopython:mainJul 10, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove _PyCompile_OpcodeHas* functions

2 participants

@iritkatriel@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp