Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-121381 Remove subprocess._USE_VFORK escape hatch#121383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This flag was added as an escape hatch inpythongh-91401 and backported toPython 3.10. The flag broke at some point between its addition and now.As there is currently no publicly known environments that require this,remove it rather than work on fixing it.This leaves the flag in the subprocess module to not break code whichmay have used / checked the flag itself.discussion:https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@gpshead: What do you think? Should we get rid of this feature, or fix it?
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
The glibc posix_spawn() can use vfork() automatically and there is no option to control it. I don't think that Python users have to decide if vfork() is used or not. At least, I don't know any good reason to disable vfork() in subprocess.
Thank you! |
)This flag was added as an escape hatch inpythongh-91401 and backported toPython 3.10. The flag broke at some point between its addition and now.As there is currently no publicly known environments that require this,remove it rather than work on fixing it.This leaves the flag in the subprocess module to not break code whichmay have used / checked the flag itself.discussion:https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
Uh oh!
There was an error while loading.Please reload this page.
This flag was added as an escape hatch inbpo-47245 and backported to Python 3.10. The flag broke at some point between its addition and now. As there is currently no publicly known environments that require this, remove it rather than work on fixing it.
discussion:https://discuss.python.org/t/subprocess-use-vfork-escape-hatch-broken-fix-or-remove/56915/2
📚 Documentation preview 📚:https://cpython-previews--121383.org.readthedocs.build/