Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal#121358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…sImmortalOlder stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).
Contributor
mgorny commentedJul 4, 2024
Thanks. I can confirm that it fixes the problem that I've hit with rustworkx and pyproject-fmt-rust. |
bedevere-bot commentedJul 16, 2024
Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 16, 2024
…_IsImmortal (pythonGH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).(cherry picked from commit956270d)Co-authored-by: Petr Viktorin <encukou@gmail.com>
GH-121851 is a backport of this pull request to the3.13 branch. |
encukou added a commit that referenced this pull requestJul 16, 2024
…y_IsImmortal (GH-121358) (GH-121851)gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (GH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).(cherry picked from commit956270d)Co-authored-by: Petr Viktorin <encukou@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…_IsImmortal (pythonGH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).
encukou added a commit to encukou/cpython that referenced this pull requestOct 3, 2024
…rt) _Py_IsImmortal (pythonGH-121358) (pythonGH-121851)pythongh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (pythonGH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).(cherry picked from commit956270d)Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull requestOct 4, 2024
…y_IsImmortal (GH-121358) (GH-124938)gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (GH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).(cherry picked from commit956270d)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Older stable ABI extensions are allowed to make immortal objects mortal.
Instead of
_Py_IsImmortal, use_PyUnicode_STATE(internedandstatically_allocated), or skip asserts altogether.