Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-102471, PEP 757: Add PyLong import and export API#121339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
f4fdbf2c2e568ef0d9525b19764f6f7fd11080e0791a7902fb70a6dd07552a70d0f942762c33a20be7a3d92bf1eb3b02a2caca2d74221a4937b1d49d70a1214aa25f690973d45d3e224c7d7cb2a3d601ac04926806b196b3e8d29686c68c2a8fd669a04f9d0b2be94aca98ad1167d75e5e53a5bc24789f0422f9da529a483db44f31d2863ed663511816798d033bd6536b87d494d852ea72ff8353d584b577598ab08cd55eaebef303248c70a26f9788a62fe45517ab92007d16d3cb80File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -703,8 +703,8 @@ Export API | ||||||||||||||||
| The function must not be called before Python initialization nor after | ||||||||||||||||
| Python finalization. The returned layout is valid until Python is | ||||||||||||||||
| finalized. The layout is the same for all Python sub-interpreters | ||||||||||||||||
| in a process, andso it can be cached. | ||||||||||||||||
| .. c:struct:: PyLongExport | ||||||||||||||||
| @@ -714,10 +714,8 @@ Export API | ||||||||||||||||
| There are two cases: | ||||||||||||||||
| * If :c:member:`digits` is ``NULL``, only use the :c:member:`value` member. | ||||||||||||||||
| * If :c:member:`digits` is not ``NULL``, use :c:member:`negative`, | ||||||||||||||||
| :c:member:`ndigits` and :c:member:`digits` members. | ||||||||||||||||
| .. c:member:: int64_t value | ||||||||||||||||
| @@ -743,20 +741,28 @@ Export API | ||||||||||||||||
| Export a Python :class:`int` object. | ||||||||||||||||
| *export_long* must point to a :c:struct:`PyLongExport` structure allocated | ||||||||||||||||
| by the caller. It must not be ``NULL``. | ||||||||||||||||
| On success,fill in *\*export_long* and return ``0``. | ||||||||||||||||
| On error, set an exception and return ``-1``. | ||||||||||||||||
| :c:func:`PyLong_FreeExport` must be called when the export is no longer | ||||||||||||||||
| needed. | ||||||||||||||||
vstinner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||||||||||||||||
| .. impl-detail:: | ||||||||||||||||
| This function always succeeds if *obj* is a Python :class:`int` object | ||||||||||||||||
| or a subclass. | ||||||||||||||||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Lets see if we can restore this in a that way. It might be helpful for e.g. Sage, which doesn't support PyPy. MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I would prefer to not add this note. It was controversial during PEP 757 design. @serhiy-storchaka@encukou: What do you think? Would you be ok to declare that the PyLong_Export() function cannot fail if the argument is a Python int? Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
It was proposed unconditionally, not as CPython's implementation detail. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'm fine with it, as an implementation detail. Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. | ||||||||||||||||
| .. c:function:: void PyLong_FreeExport(PyLongExport *export_long) | ||||||||||||||||
| Release the export *export_long* created by :c:func:`PyLong_Export`. | ||||||||||||||||
| .. impl-detail:: | ||||||||||||||||
| Calling :c:func:`PyLong_FreeExport` is optional if *export_long->digits* | ||||||||||||||||
| is ``NULL``. | ||||||||||||||||
| PyLongWriter API | ||||||||||||||||
| ^^^^^^^^^^^^^^^^ | ||||||||||||||||
| @@ -787,12 +793,18 @@ The :c:type:`PyLongWriter` API can be used to import an integer. | ||||||||||||||||
| *digits* must not be NULL. | ||||||||||||||||
| After a successful call to this function, the caller should fill in the | ||||||||||||||||
| array of digits *digits* and then call :c:func:`PyLongWriter_Finish` to get | ||||||||||||||||
| a Python :class:`int`. | ||||||||||||||||
| The layout of *digits* is described by :c:func:`PyLong_GetNativeLayout`. | ||||||||||||||||
| Digits must be in the range [``0``; ``(1 << bits_per_digit) - 1``] | ||||||||||||||||
| (where the :c:struct:`~PyLongLayout.bits_per_digit` is the number of bits | ||||||||||||||||
| per digit). | ||||||||||||||||
| Any unused most significant digits must be set to ``0``. | ||||||||||||||||
vstinner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||||||||||||||||
| Alternately, call :c:func:`PyLongWriter_Discard` to destroy the writer | ||||||||||||||||
| instance without creating an :class:`~int` object. | ||||||||||||||||
| .. c:function:: PyObject* PyLongWriter_Finish(PyLongWriter *writer) | ||||||||||||||||
| @@ -805,7 +817,7 @@ The :c:type:`PyLongWriter` API can be used to import an integer. | ||||||||||||||||
| The function takes care of normalizing the digits and converts the object | ||||||||||||||||
| to a compact integer if needed. | ||||||||||||||||
| The writer instanceand the *digits* array are invalid after the call. | ||||||||||||||||
| .. c:function:: void PyLongWriter_Discard(PyLongWriter *writer) | ||||||||||||||||
| @@ -814,4 +826,4 @@ The :c:type:`PyLongWriter` API can be used to import an integer. | ||||||||||||||||
| *writer* must not be ``NULL``. | ||||||||||||||||
| The writer instanceand the *digits* array are invalid after the call. | ||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6797,6 +6797,7 @@ int | ||
| PyLong_Export(PyObject *obj, PyLongExport *export_long) | ||
| { | ||
| if (!PyLong_Check(obj)) { | ||
vstinner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page.
vstinner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| memset(export_long, 0, sizeof(*export_long)); | ||
| PyErr_Format(PyExc_TypeError, "expect int, got %T", obj); | ||
| return -1; | ||
| } | ||
Uh oh!
There was an error while loading.Please reload this page.