Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-102471, PEP 757: Add PyLong import and export API#121339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
f4fdbf2c2e568ef0d9525b19764f6f7fd11080e0791a7902fb70a6dd07552a70d0f942762c33a20be7a3d92bf1eb3b02a2caca2d74221a4937b1d49d70a1214aa25f690973d45d3e224c7d7cb2a3d601ac04926806b196b3e8d29686c68c2a8fd669a04f9d0b2be94aca98ad1167d75e5e53a5bc24789f0422f9da529a483db44f31d2863ed663511816798d033bd6536b87d494d852ea72ff8353d584b577598ab08cd55eaebef303248c70a26f9788a62fe45517ab92007d16d3cb80File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -749,7 +749,8 @@ Export API | ||||||||||||||||
| On error, set an exception and return ``-1``. | ||||||||||||||||
| If *export_long->digits* is not ``NULL``, :c:func:`PyLong_FreeExport` must | ||||||||||||||||
| be called when the export is no longer needed. Otherwise, calling | ||||||||||||||||
| :c:func:`PyLong_FreeExport` is optional. | ||||||||||||||||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Lets see if we can restore this in a that way. It might be helpful for e.g. Sage, which doesn't support PyPy. MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I would prefer to not add this note. It was controversial during PEP 757 design. @serhiy-storchaka@encukou: What do you think? Would you be ok to declare that the PyLong_Export() function cannot fail if the argument is a Python int? Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
It was proposed unconditionally, not as CPython's implementation detail. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'm fine with it, as an implementation detail. Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. | ||||||||||||||||
| .. c:function:: void PyLong_FreeExport(PyLongExport *export_long) | ||||||||||||||||
Uh oh!
There was an error while loading.Please reload this page.