NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-121300: Add`replace` to`copy.all`#121302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 6 commits intopython:mainfrommax-muoto:add-replace-to-all

Jul 3, 2024

Merged

gh-121300: Add`replace` to`copy.all`#121302

kumaraditya303 merged 6 commits intopython:mainfrommax-muoto:add-replace-to-all

Jul 3, 2024

Conversation

Copy link

Contributor

max-muoto commentedJul 3, 2024•
edited by bedevere-appbot
Loading

Adds missing replace tocopy.__all__

Issue:3.13copy.replace isn't in__all__ #121300

Addreplace tocopy.__all__

3289006

Copy link

ghost commentedJul 3, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appbot mentioned this pull request

Jul 3, 2024

3.13copy.replace isn't in__all__#121300

Closed

Copy link

bedevere-appbot commentedJul 3, 2024

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

bedevere-appbot added the awaiting review label

Jul 3, 2024

Merge branch 'main' into add-replace-to-all

0138a94

Copy link

bedevere-appbot commentedJul 3, 2024

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

serhiy-storchaka approved these changes

Jul 3, 2024

View reviewed changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

bedevere-appbot added awaiting merge and removed awaiting review labels

Jul 3, 2024

serhiy-storchaka added skip news needs backport to 3.13bugs and security fixes labels

Jul 3, 2024

serhiy-storchakaenabled auto-merge (squash)

July 3, 2024 05:43

pygeek reviewed

Jul 3, 2024

View reviewed changes

Lib/copy.py

		error=Error# backward compatibility

		__all__= ["Error","copy","deepcopy"]
		__all__= ["Error","copy","deepcopy","replace"]

Copy link

Contributor

pygeekJul 3, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider adding a regression test so this doesn't happen again. See helper methodsupport.test__all__ in the test directory—it automatically detects public methods based on whether they follow the public name convention.

Copy link

ContributorAuthor

max-muotoJul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure, let me go ahead, good callout.

max-muotodisabled auto-merge

July 3, 2024 05:50

max-muoto added2 commits

July 3, 2024 00:55

Add test case

4bdb564

Update interface docs

09a8e59

Copy link

ContributorAuthor

max-muoto commentedJul 3, 2024

@serhiy-storchaka If you want to take another look.

max-muoto added2 commits

July 3, 2024 01:09

Update test_copy.py

2854dfc

Merge branch 'main' into add-replace-to-all

49e3338

Eclips4 approved these changes

Jul 3, 2024

View reviewed changes

Copy link

Member

Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

kumaraditya303 approved these changes

Jul 3, 2024

View reviewed changes

JelleZijlstra approved these changes

Jul 3, 2024

View reviewed changes

kumaraditya303 merged commit7c66906 intopython:main

Jul 3, 2024

Copy link

miss-islington-appbot commentedJul 3, 2024

Thanks@max-muoto for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

Jul 3, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 3, 2024

pythongh-121300: Addreplacetocopy.__all__(pythonGH-121302)

1d975af

(cherry picked from commit7c66906)Co-authored-by: Max Muoto <maxmuoto@gmail.com>

Copy link

bedevere-appbot commentedJul 3, 2024

GH-121337 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

Jul 3, 2024

JelleZijlstra pushed a commit that referenced this pull request

Jul 3, 2024

[3.13]gh-121300: Addreplacetocopy.__all__(GH-121302) (#121337)

8799f05

(cherry picked from commit7c66906)Co-authored-by: Max Muoto <maxmuoto@gmail.com>

Copy link

bedevere-bot commentedJul 3, 2024

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commit7c66906.

What do you need to do:

Don't panic.
Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8418) and take a look at the build logs.
Check if the failure is related to this commit (7c66906) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8418

Failed tests:

test_repl

Failed subtests:

test_asyncio_repl_is_ok - test.test_repl.TestInteractiveInterpreter.test_asyncio_repl_is_ok

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_repl.py", line199, intest_asyncio_repl_is_ok    assert_python_ok("-m","asyncio")~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line182, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line167, in_assert_python    res.fail(cmd_line)~~~~~~~~^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line80, infailraiseAssertionError(f"Process return code is{exitcode}\n"...<10 lines>...f"---")AssertionError:Process return code is -6 (SIGABRT)command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-I', '-m', 'asyncio']Traceback (most recent call last):xiting asyncio REPL...  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/asyncio/__main__.py", line109, inrunraiseOSError(errno.ENOTTY,"tty required","stdin")Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threadsPython runtime state: finalizing (tstate=0x0000562ad21ccb50)Traceback (most recent call last):xiting asyncio REPL...  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/asyncio/__main__.py", line109, inrunraiseOSError(errno.ENOTTY,"tty required","stdin")Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threadsPython runtime state: finalizing (tstate=0x000055c24a873b50)