Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-121272: compiler no longer modifies the symtable, ste_coroutine always set during symtable construction#121297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| compiler_exit_scope(c); | ||
| if (is_top_level_await&&is_async_generator){ | ||
| c->u->u_ste->ste_coroutine=1; | ||
| assert(c->u->u_ste->ste_coroutine==1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this assignment has been obsolete for a while now, see#6766 (comment).
JelleZijlstra left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Agree this is a job for the symtable, not the compiler. This looks to be well tested intest_compile_top_level_await in test_builtin.py.
…on#121297)compiler no longer modifies the symtable after this.
…on#121297)compiler no longer modifies the symtable after this.
Uh oh!
There was an error while loading.Please reload this page.