Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-121285: Remove backtracking when parsing tarfile headers#121286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gpshead merged 11 commits intopython:mainfromsethmlarson:remove-backtracking-tarfile-membersAug 31, 2024
Merged
gh-121285: Remove backtracking when parsing tarfile headers#121286
gpshead merged 11 commits intopython:mainfromsethmlarson:remove-backtracking-tarfile-membersAug 31, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Security/2024-07-02-13-39-20.gh-issue-121285.hrl-yI.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…hrl-yI.rstCo-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Member
hugovk commentedJul 2, 2024
@sethmlarson Did you mean to add the "Needs backport to 3.x" labels rather than the "3.x" ones? |
ContributorAuthor
sethmlarson commentedJul 2, 2024
@hugovk Yes! Selected the wrong range of tags, my bad. |
ethanfurman requested changesJul 2, 2024
Member
ethanfurman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please remove the type hints.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
sethmlarson added a commit to sethmlarson/cpython that referenced this pull requestSep 3, 2024
…ers (pythonGH-121286)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-123639 is a backport of this pull request to the3.11 branch. |
GH-123639 is a backport of this pull request to the3.11 branch. |
sethmlarson added a commit to sethmlarson/cpython that referenced this pull requestSep 3, 2024
…ers (pythonGH-121286)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-123640 is a backport of this pull request to the3.10 branch. |
sethmlarson added a commit to sethmlarson/cpython that referenced this pull requestSep 3, 2024
…rs (pythonGH-121286)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-123641 is a backport of this pull request to the3.9 branch. |
sethmlarson added a commit to sethmlarson/cpython that referenced this pull requestSep 3, 2024
…rs (pythonGH-121286)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-123642 is a backport of this pull request to the3.8 branch. |
ContributorAuthor
sethmlarson commentedSep 3, 2024
Backports have been created. |
pablogsal pushed a commit that referenced this pull requestSep 3, 2024
…H-121286) (#123639)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
pablogsal pushed a commit that referenced this pull requestSep 3, 2024
…H-121286) (#123640)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull requestSep 4, 2024
…-121286) (#123642)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull requestSep 4, 2024
…-121286) (#123641)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness pushed a commit to frenzymadness/cpython that referenced this pull requestSep 5, 2024
…e headers (pythonGH-121286) (python#123642)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness added a commit to frenzymadness/cpython that referenced this pull requestSep 5, 2024
…e headers (pythonGH-121286) (python#123642)* Remove backtracking when parsing tarfile headers* Rewrite PAX header parsing to be stricter* Optimize parsing of GNU extended sparse headers v0.0(cherry picked from commit34ddb64)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Lumír Balhar <lbalhar@redhat.com>
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 6, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 9, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 10, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 10, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 10, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull requestMay 14, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 15, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
rickprice added a commit to ActiveState/cpython that referenced this pull requestMay 15, 2025
…nGH-121286)Patched from:https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patchHad one reject, hand updated it.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This removes all instances of backtracking from parsing tarfile headers, specifically
hdrcharset, PAX, and GNU sparse headers.