Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.12] gh-113565: Improve and harden detection of curses dependencies (#119816)#121222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJul 1, 2024
edited by bedevere-appbot
Loading

(cherry picked from commitf80376b)

  1. Use pkg-config to check for ncursesw/panelw. If that fails, use
    pkg-config to check for ncurses/panel.
  2. Regardless of pkg-config output, search for curses/panel headers, so
    we're sure we have all defines in pyconfig.h.
  3. Regardless of pkg-config output, check if libncurses or libncursesw
    contains the 'initscr' symbol; if it doesand pkg-config failed
    earlier, add the resulting -llib linker option to CURSES_LIBS.
    Ditto for 'update_panels' and PANEL_LIBS.
  4. Wrap the rest of the checks with WITH_SAVE_ENV and make sure we're
    using updated LIBS and CPPFLAGS for those.

Add the PY_CHECK_CURSES convenience macro.

…encies (python#119816)(cherry picked from commitf80376b)1. Use pkg-config to check for ncursesw/panelw. If that fails, use   pkg-config to check for ncurses/panel.2. Regardless of pkg-config output, search for curses/panel headers, so   we're sure we have all defines in pyconfig.h.3. Regardless of pkg-config output, check if libncurses or libncursesw   contains the 'initscr' symbol; if it does _and_ pkg-config failed   earlier, add the resulting -llib linker option to CURSES_LIBS.   Ditto for 'update_panels' and PANEL_LIBS.4. Wrap the rest of the checks with WITH_SAVE_ENV and make sure we're   using updated LIBS and CPPFLAGS for those.Add the PY_CHECK_CURSES convenience macro.
@erlend-aasland
Copy link
ContributorAuthor

Marked as DO-NOT-MERGE and left to@Yhg1s to decide. See#119816 (comment).

@erlend-aasland
Copy link
ContributorAuthor

@Yhg1s
Copy link
Member

It's difficult, but I think this is too invasive for 3.12. It's too easy for this to breakother systems doing automated/scripted builds, both because of the autoconf changes and the differences in which defines are used. We don't want to play use-case-whackamole where we keep breaking one system in our attempts to fix another.

erlend-aasland reacted with thumbs up emoji

@erlend-aaslanderlend-aasland deleted the backport-3.12-autoconf-curses branchAugust 3, 2024 22:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@Yhg1s

[8]ページ先頭

©2009-2025 Movatter.jp