NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

[3.12] gh-121018: Fix more cases of exiting in argparse when exit_on_error=False (GH-121056)#121129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.12fromserhiy-storchaka:backport-81a654a-3.12

Jun 28, 2024

Merged

[3.12] gh-121018: Fix more cases of exiting in argparse when exit_on_error=False (GH-121056)#121129

serhiy-storchaka merged 1 commit intopython:3.12fromserhiy-storchaka:backport-81a654a-3.12

Jun 28, 2024

Conversation

Copy link

Member

serhiy-storchaka commentedJun 28, 2024•
edited by bedevere-appbot
Loading

parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.
Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.

(cherry picked from commit81a654a)

Issue:argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments #121018

[3.12]pythongh-121018: Fix more cases of exiting in argparse when ex…

8ad9e73

…it_on_error=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling  error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling  error(). It is then caught at the higher level and error() is called if  exit_on_error is true.(cherry picked from commit81a654a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

This was referencedJun 28, 2024

argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments#121018

Closed

gh-121018: Fix more cases of exiting in argparse when exit_on_error=False#121056

Merged