NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

[3.13] gh-105623 Fix performance degradation in logging RotatingFileHandler (GH-105887)#121117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.13frommiss-islington:backport-e9b4ec6-3.13

Jun 28, 2024

Merged

[3.13] gh-105623 Fix performance degradation in logging RotatingFileHandler (GH-105887)#121117

serhiy-storchaka merged 1 commit intopython:3.13frommiss-islington:backport-e9b4ec6-3.13

Jun 28, 2024

Conversation

Copy link

Contributor

miss-islington commentedJun 28, 2024•
edited by bedevere-appbot
Loading

The check for whether the log file is a real file is expensive on NFS
filesystems. This commit reorders the rollover condition checking to
not do the file type check if the expected file size is less than the
rotation threshold.

(cherry picked from commite9b4ec6)

Co-authored-by: Craig Robsoncraig@zhatt.com
Co-authored-by: Oleg Iaryginoleg@arhadthedev.net

Issue:Poor performance on logging.RotatingFileHandler due to fix to #89564 #105623

pythongh-105623Fix performance degradation in logging RotatingFileHa…

6e494b3

…ndler (pythonGH-105887)The check for whether the log file is a real file is expensive on NFSfilesystems.  This commit reorders the rollover condition checking tonot do the file type check if the expected file size is less than therotation threshold.(cherry picked from commite9b4ec6)Co-authored-by: Craig Robson <craig@zhatt.com>Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>