NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-121027: Make the functools.partial object a method descriptor#121089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:partial-get

Jul 3, 2024

Merged

gh-121027: Make the functools.partial object a method descriptor#121089

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:partial-get

Jul 3, 2024

Conversation

Copy link

Member

serhiy-storchaka commentedJun 27, 2024•
edited by github-actionsbot
Loading

Co-authored-by: d.grigonisdgrigonis@users.noreply.github.com

Issue:Add __get__ to the partial object #121027

📚 Documentation preview 📚:https://cpython-previews--121089.org.readthedocs.build/

serhiy-storchaka requested a review fromrhettinger

June 27, 2024 11:22

bedevere-appbot mentioned this pull request

Jun 27, 2024

Add __get__ to the partial object#121027

Closed

bedevere-appbot added the awaiting core review label

Jun 27, 2024

serhiy-storchaka force-pushed thepartial-get branch from5ecccee to693fbc7Compare

June 27, 2024 11:23

Copy link

Contributor

nineteendo commentedJun 27, 2024•
edited
Loading

This should have been labeled as "DO-NOT-MERGE" until#121086 was merged. There are conflicts anyway now.

pythongh-121027: Make the functools.partial object a method descriptor

d752505

Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>

serhiy-storchaka force-pushed thepartial-get branch from693fbc7 tod752505Compare

June 27, 2024 11:56

serhiy-storchaka commented

Jun 27, 2024

View reviewed changes

Doc/whatsnew/3.14.rst OutdatedShow resolvedHide resolved

Lib/functools.py

		@@ -402,7 +398,7 @@ def _method(cls_or_self, /, args, *keywords):
		def __get__(self, obj, cls=None):
		get = getattr(self.func, "__get__", None)
		result = None
		if get is not None and not isinstance(self.func, partial):
		if get is not None:

Copy link

MemberAuthor

serhiy-storchakaJun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It was needed to avoid emitting a warning forpartialmethod(partial(...)), even if the final behavior is not changed.

serhiy-storchaka commented

Jun 27, 2024

View reviewed changes

Doc/whatsnew/3.14.rst OutdatedShow resolvedHide resolved

Update Doc/whatsnew/3.14.rst

fab5797

rhettinger approved these changes

Jun 30, 2024

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Jun 30, 2024

serhiy-storchaka merged commitff5806c intopython:main

Jul 3, 2024

38 checks passed

bedevere-appbot removed the awaiting merge label

Jul 3, 2024

serhiy-storchaka deleted the partial-get branch

July 3, 2024 06:02

Copy link

bedevere-bot commentedJul 3, 2024

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commitff5806c.

What do you need to do:

Don't panic.
Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1226/builds/2167) and take a look at the build logs.
Check if the failure is related to this commit (ff5806c) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1226/builds/2167

Failed tests:

test.test_concurrent_futures.test_thread_pool

Failed subtests:

test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line130, intest_free_referenceself.assertIsNone(wr())~~~~~~~~~~~~~~~~~^^^^^^AssertionError:<test.test_concurrent_futures.executor.MyObject object at 0x20002080170> is not NoneTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line130, intest_free_referenceself.assertIsNone(wr())~~~~~~~~~~~~~~~~~^^^^^^AssertionError:<test.test_concurrent_futures.executor.MyObject object at 0x20006090090> is not None

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request

Jul 11, 2024

pythongh-121027: Make the functools.partial object a method descriptor (

111f9cf

pythonGH-121089)Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024

pythongh-121027: Make the functools.partial object a method descriptor (

d56f949

pythonGH-121089)Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>

JelleZijlstra mentioned this pull request

Sep 28, 2024

functools: Give up on lazy-importing types#124736

Merged

JelleZijlstra added a commit that referenced this pull request

Sep 29, 2024

functools: Give up on lazy-importing types (#124736)

95581b3

PR#121089 added an eager import for types.MethodType, butstill left the existing hacks for lazily importing from types.We could also create MethodType internally in functools.py (e.g.,by using `type(Placeholder.__repr__)`, but it feels not worth it atthis point, so instead I unlazified all the usages of types in themodule.