Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-121018: Fix more cases of exiting in argparse when exit_on_error=False#121056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:argparse-exit_on_errorJun 28, 2024
Merged
gh-121018: Fix more cases of exiting in argparse when exit_on_error=False#121056
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:argparse-exit_on_errorJun 28, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rror=False* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at higher level and error() is called if exit_on_error is true.
This was referencedJun 26, 2024
81a654a intopython:main 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJun 28, 2024
…it_on_error=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.(cherry picked from commit81a654a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-121128 is a backport of this pull request to the3.13 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJun 28, 2024
…it_on_error=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.(cherry picked from commit81a654a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-121129 is a backport of this pull request to the3.12 branch. |
serhiy-storchaka added a commit that referenced this pull requestJun 28, 2024
…error=False (GH-121056) (GH-121129)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.(cherry picked from commit81a654a)
serhiy-storchaka added a commit that referenced this pull requestJun 28, 2024
…error=False (GH-121056) (GH-121128)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.(cherry picked from commit81a654a)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull requestJun 30, 2024
…rror=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
…rror=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…rror=False (pythonGH-121056)* parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.* Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.