Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-120522: Add a--with-app-store-compliance configure option to patch out problematic code#120984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes from1 commit
e30787fae53183eee0c93eeb976f26cd9ae2d5a0a712cb469eb4898756f7487cb22667a7a1275702466c87a8e72955dd67File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -932,10 +932,18 @@ $(BUILDPYTHON)-gdb.py: $(SRC_GDB_HOOKS) | ||
| # Compliance with app stores (such as iOS and macOS) sometimes requires making | ||
| # modifications to the Python standard library. If enabled, apply the patch of | ||
| # known modifications to the source tree before building. The patch will be | ||
| # applied in a dry-run mode (validating, but not applying the patch) on builds | ||
| # that *have* a compliance patch, but where compliance has not been enabled. | ||
| build/app-store-compliant: | ||
| patch @APP_STORE_COMPLIANCE_PATCH_FLAGS@ --forward --strip=1 --directory="$(srcdir)" --input "$(APP_STORE_COMPLIANCE_PATCH)" ; \ | ||
| if test "@APP_STORE_COMPLIANCE_PATCH_FLAGS@" == ""; then \ | ||
| echo "Source tree has been patched for app store compliance."; \ | ||
| mkdir -p build ; \ | ||
| echo "$(APP_STORE_COMPLIANCE_PATCH)" > build/app-store-compliant ; \ | ||
| else \ | ||
| echo "App store compliance patch has been verified, but not applied."; \ | ||
erlend-aasland marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| fi | ||
| # This rule is here for OPENSTEP/Rhapsody/MacOSX. It builds a temporary | ||
| # minimal framework (not including the Lib directory and such) in the current | ||
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -710,7 +710,7 @@ AC_ARG_WITH( | ||
| Darwin|iOS) | ||
| # iOS is able to share the macOS patch | ||
| APP_STORE_COMPLIANCE_PATCH="Mac/Resources/app-store-compliance.patch" | ||
| APP_STORE_COMPLIANCE_PATCH_TARGET="build/app-store-compliant" | ||
| APP_STORE_COMPLIANCE_PATCH_FLAGS= | ||
| ;; | ||
| *) AC_MSG_ERROR([No default app store compliance patch available for $ac_sys_system]) ;; | ||
freakboy3742 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| @@ -719,7 +719,7 @@ AC_ARG_WITH( | ||
| ;; | ||
| *) | ||
| APP_STORE_COMPLIANCE_PATCH="${withval}" | ||
| APP_STORE_COMPLIANCE_PATCH_TARGET="build/app-store-compliant" | ||
| APP_STORE_COMPLIANCE_PATCH_FLAGS= | ||
| AC_MSG_RESULT(["applying custom app store compliance patch"]) | ||
freakboy3742 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| ;; | ||
| @@ -729,14 +729,14 @@ AC_ARG_WITH( | ||
| iOS) | ||
| # Always apply the compliance patch on iOS; we can use the macOS patch | ||
| APP_STORE_COMPLIANCE_PATCH="Mac/Resources/app-store-compliance.patch" | ||
| APP_STORE_COMPLIANCE_PATCH_TARGET="build/app-store-compliant" | ||
| APP_STORE_COMPLIANCE_PATCH_FLAGS= | ||
| AC_MSG_RESULT(["applying default app store compliance patch"]) | ||
freakboy3742 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| ;; | ||
| Darwin) | ||
| # Always *check* the compliance patch on macOS | ||
| APP_STORE_COMPLIANCE_PATCH="Mac/Resources/app-store-compliance.patch" | ||
| APP_STORE_COMPLIANCE_PATCH_TARGET="build/app-store-compliant" | ||
| APP_STORE_COMPLIANCE_PATCH_FLAGS="--dry-run" | ||
| AC_MSG_RESULT(["checking (not applying) default app store compliance patch"]) | ||
freakboy3742 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| ;; | ||