Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-120678: pyrepl: Include globals from modules passed with-i#120904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 9 commits intopython:mainfromAlexWaygood:repl-globals
Jul 17, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commentedJun 23, 2024•
edited
Loading

In order to fix the regression caused by#119547, this PR goes back to the original fix that was proposed in the early commits of#119547.

The REPL must use the globals fromsys.modules["__main__"] in case a different module has been run as__main__ using-i; in order to prevent globals from_pyrepl.__main__ from leaking into the global namespace, we move the vast majority of the globals out of__main__.py instead of running the REPL with an entirely fresh set of globals.

Some small filtering of globals is additionally done inLib/_pyrepl/simple_interact.py, so that we're able to import functions and classes in_pyrepl.__main__ without these globals leaking into the REPL environment. (This filtering only works for things with__module__ attributes, though, so it's still best to keep_pyrepl/__main__.py as minimal as possible.)

This still doesn'texactly match the behaviour of the old REPL for some dunders:

~/dev/cpython (repl-globals)⚡ % cat foo.py           """For fooey things"""FOO: int = 42~/dev/cpython (repl-globals)⚡ % PYTHON_BASIC_REPL=1 ./python.exe -i foo.py>>>__doc__'For fooey things'>>>exit()~/dev/cpython (repl-globals)⚡ % ./python.exe -i foo.py                    >>>__doc__>>>

I'm not really sure why that is!

@AlexWaygood
Copy link
MemberAuthor

Cc.@eryksun if you're interested!

Copy link
Contributor

@eryksuneryksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you. LGTM 🚀

AlexWaygood reacted with hooray emoji
@ambv
Copy link
Contributor

Sorry, didn't notice this was the same asgh-121054 as I looked at the root cause, which wasgh-118908.

Let's keep this for additional test you added, and the__main__ comment to not add things there.

@ambv
Copy link
Contributor

ambv commentedJun 26, 2024•
edited
Loading

The reason why__cached__,__file__,__package__,__spec__, and__doc__ are wrong is that PyREPL is also a package now, and it's started after the fact in the same namespace. So it effectively overwrites those attributes from what was previously set:

>>>__package__'_pyrepl'>>>__name__'__main__'>>>__spec__ModuleSpec(name='_pyrepl.__main__', loader=<_frozen_importlib_external.SourceFileLoader object at 0x103a020c0>, origin='/Volumes/RAMDisk/cpython/Lib/_pyrepl/__main__.py')>>>__file__'/Volumes/RAMDisk/cpython/Lib/_pyrepl/__main__.py'

We'd need to work around that.

@@ -487,6 +489,18 @@ def prepare_reader(self, events):
reader.can_colorize = False
return reader

def test_stdin_is_tty(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was helpful to me when debugging weird behavior so I decided to keep it.

@@ -549,7 +597,7 @@ pymain_repl(PyConfig *config, int *exitcode)
*exitcode = (run != 0);
return;
}
int run =pymain_run_module(L"_pyrepl", 0);
int run =pymain_start_pyrepl_no_main();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My first intuition was to simplyPyImport_ImportModule("_pyrepl.__main__") but then the entire shell session is a side-effect of an on-going import, which was ugly and caused some funny edge cases (a non-zero exit was technically an ImportError).

So instead we do the full dance of running_pyrepl.main.interactive_console(). While doing that I'm smuggling PYTHONSTARTUP support because:

  • you can always remove PYTHONSTARTUP from your environment to not have it;
  • but previously you could not get PYTHONSTARTUP to be executed even if you wanted.

@AlexWaygood
Copy link
MemberAuthor

Thanks for picking this up@ambv!

@ambv
Copy link
Contributor

It's team work: I push the shoddy changes, you get thegit blame!

AlexWaygood reacted with rocket emoji

Copy link
MemberAuthor

@AlexWaygoodAlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't give an approving review (since this is strictly speaking still "my PR" 😄), but from what I can tell this all LGTM! (With the caveat that I'm far from the world's greatest C programmer, so I could easily have missed something)

@ambvambv merged commitac07451 intopython:mainJul 17, 2024
44 checks passed
@miss-islington-app
Copy link

Thanks@AlexWaygood for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 17, 2024
pythonGH-120904)(cherry picked from commitac07451)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-121916 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 17, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1225/builds/2684) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1225/builds/2684

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/424/builds/7678) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/424/builds/7678

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x SLES 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/540/builds/9493) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/540/builds/9493

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Debian 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/49/builds/9540) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/49/builds/9540

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

ambv added a commit that referenced this pull requestJul 17, 2024
…i` (GH-120904) (#121916)(cherry picked from commitac07451)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1422/builds/284) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1422/builds/284

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x SLES 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1437/builds/356) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1437/builds/356

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.13.edelsohn-sles-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1435/builds/346) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1435/builds/346

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/var/lib/buildbot/workers/3.13.gps-raspbian.nondebug/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Debian 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1485/builds/353) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1485/builds/353

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.13.edelsohn-debian-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel ASAN NoGIL 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1366/builds/1670) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1366/builds/1670

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel NoGIL 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1258/builds/2373) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1258/builds/2373

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@AlexWaygoodAlexWaygood deleted the repl-globals branchJuly 17, 2024 15:22
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 MacOS M1 NoGIL 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1408/builds/287) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1408/builds/287

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1441/builds/318) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1441/builds/318

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/506/builds/8352) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/506/builds/8352

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel ASAN NoGIL 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1460/builds/322) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1460/builds/322

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/345/builds/8507) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/345/builds/8507

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel NoGIL 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1449/builds/323) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1449/builds/323

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/469/builds/8577) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/469/builds/8577

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Windows10 3.x has failed when building commitac07451.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/146/builds/9086) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac07451) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/146/builds/9086

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_pyrepl\test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1450/builds/273) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1450/builds/273

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/test/test_pyrepl/test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Windows10 3.13 has failed when building commit3d9692d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1501/builds/301) and take a look at the build logs.
  4. Check if the failure is related to this commit (3d9692d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1501/builds/301

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"D:\buildarea\3.13.bolen-windows10\build\Lib\test\test_pyrepl\test_pyrepl.py", line500, intest_stdout_is_ttyif os.isatty(sys.stdout.fileno()):~~~~~~~~~~~~~~~~~^^io.UnsupportedOperation:fileno

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvambv left review comments

@eryksuneryksuneryksun approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Labels
topic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@AlexWaygood@ambv@bedevere-bot@eryksun
[8]ページ先頭
©2009-2025 Movatter.jp