Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

[3.13] gh-120782: Update internal type cache when reloading datetime (GH-120829)#120855

Merged
kumaraditya303 merged 7 commits intopython:3.13from
neonene:reload313
Jul 3, 2024
Merged

[3.13] gh-120782: Update internal type cache when reloading datetime (GH-120829)#120855
kumaraditya303 merged 7 commits intopython:3.13from
neonene:reload313

Conversation

@neonene
Copy link
Contributor

@neoneneneonene commentedJun 21, 2024
edited
Loading

When reloading_datetime module, the single-phase version did not invoke thePyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.

This PR is a manual backport ofa81d434, addingassert statements to the test case.
This also backportse6076d1 (gh-120180) manually.

When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.
@neonene
Copy link
ContributorAuthor

@neonene
Copy link
ContributorAuthor

neonene commentedJun 22, 2024
edited
Loading

@ericsnowcurrently I backportede6076d1 as well. (I can take back the change:09ec032)

ericsnowcurrently reacted with thumbs up emoji

@kumaraditya303kumaraditya303 merged commit2c3aa52 intopython:3.13Jul 3, 2024
@neonene
Copy link
ContributorAuthor

Thanks.

@neoneneneonene deleted the reload313 branchJuly 3, 2024 12:34
@freakboy3742
Copy link
Contributor

This backport appears to have broken the iOS buildbot. I’m AFK for the next week; I’ll take a look when I’m back at my desk.

@neonene
Copy link
ContributorAuthor

This backport appears to have broken the iOS buildbot.

#121561 should be effective for fixing it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neonene@freakboy3742@JelleZijlstra@kumaraditya303

[8]ページ先頭

©2009-2026 Movatter.jp