Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-119258: Backport optimizer frame fixes in GH-119365#120699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commentedJun 18, 2024•
edited by bedevere-appbot
Loading

Removes frame overlapping, instead copy over their arguments directly.

@Fidget-Spinner
Copy link
MemberAuthor

Skip news as it's a experimental feature.

@Fidget-SpinnerFidget-Spinner changed the titlegh-119258: Backport optimizer frame fixes in GH-119365[3.13] gh-119258: Backport optimizer frame fixes in GH-119365Jun 18, 2024
@brandtbucher
Copy link
Member

brandtbucher commentedJun 18, 2024•
edited
Loading

Does this mean we can correctly optimize across_PY_FRAME_GENERAL now instead of bailing?

@Fidget-Spinner
Copy link
MemberAuthor

I think we were already doing that. This just fixes a bug with overlapping frames (it removes it altogether).

@Fidget-Spinner
Copy link
MemberAuthor

Merging this as backport bugfixes don't normally need approval (or at least, I can approve it if it were done by the bot).

@Fidget-SpinnerFidget-Spinner merged commit7c7aa5a intopython:3.13Jun 20, 2024
@Fidget-SpinnerFidget-Spinner deleted the optim_frame_backport branchJune 20, 2024 15:55
@brandtbucher
Copy link
Member

I think we were already doing that. This just fixes a bug with overlapping frames (it removes it altogether).

Maybe I'm misunderstanding. Is there anything preventing us from updating_PY_FRAME_GENERAL in the optimizer to push a new frame and continue optimizing, rather than bailing (like it does now)?

@Fidget-Spinner
Copy link
MemberAuthor

IIRC we used to not be able to determine the size of the nee frame to push which is why we bailed. If that's solved I dont see why we cant toptimize through it.

@markshannon
Copy link
Member

markshannon commentedJun 21, 2024•
edited
Loading

_Py_uop_frame_new still assumes positional arguments only, but it would be simple enough to drop that assumption by initializing the arguments in the caller.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner@brandtbucher@markshannon
[8]ページ先頭
©2009-2025 Movatter.jp