Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-118943: Fix another race condition when generating jit_stencils.h#120690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 2 commits intopython:mainfromhroncok:jitmakerace
Aug 5, 2024

Conversation

@hroncok
Copy link
Contributor

@hroncokhroncok commentedJun 18, 2024•
edited by bedevere-appbot
Loading

Another process might have already moved jit_stencils.h.new

…ils.hAnother process might have already moved jit_stencils.h.new
…7nn.rstCo-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@brandtbucher
Copy link
Member

Thanks for this, it seems like a nice fix for the issue.

More generally though, I'm surprised that twojit_stencils.h files are being written in parallel like this for the same build. That shouldn't be happening, normally.

This seems to be the source of all of the issues you've been finding. Our Makefile is set up to only run one of these jobs permake target... I'm not sure that running several targets (likeregen-all andall) in parallel is really intended. Is that what your build does?

@brandtbucherbrandtbucher added buildThe build process and cross-build needs backport to 3.13bugs and security fixes topic-JIT labelsJun 18, 2024
@hroncok
Copy link
ContributorAuthor

We run regen-all first, then all. Are you interested in full logs?

@brandtbucher
Copy link
Member

Ah, I think I see the issue!regen-jit is part ofregen-all, butregen-all already builds the JIT for other reasons.

I think we should removeregen-jit from theregen-all target. It's really intended for files that will be checked in and aren't generated as part of the normal build.

hroncok reacted with thumbs up emoji

@hroncok
Copy link
ContributorAuthor

This was not merged in time for 3.13.0b3. How can I move this forward?

@hroncok
Copy link
ContributorAuthor

@brandtbucher Could you please merge this? Is this waiting for something else?

@hroncok
Copy link
ContributorAuthor

@Yhg1s Hey Thomas. We have carried this patch in Fedora since 3.13.0b2. Is there any chance we could get this merged to at least 3.13.0rc2?

@Eclips4
Copy link
Member

Eclips4 commentedAug 1, 2024•
edited
Loading

@Yhg1s Hey Thomas. We have carried this patch in Fedora since 3.13.0b2. Is there any chance we could get this merged to at least 3.13.0rc2?

I've pinged Brandt in the private coredev chat on Discord to get his attention.

hroncok reacted with heart emoji

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for letting this slip! Looks good to me. One thing, though: can you also removeregen-jit from theregen-all target inMakefile.pre.in?

@Yhg1s I think this is reasonable to backport to the next RC. It's just minor fixes for race conditions in the JIT build (thanks@hroncok for your work to make it available on Fedora).

@brandtbucherbrandtbucher self-assigned thisAug 1, 2024
@Yhg1s
Copy link
Member

Sure, this is fine to get in 3.13.0rc2.

brandtbucher reacted with thumbs up emojihroncok reacted with heart emoji

@hroncok
Copy link
ContributorAuthor

One thing, though: can you also removeregen-jit from theregen-all target inMakefile.pre.in?

I'm happy to do that in a separate PR.

@hroncok
Copy link
ContributorAuthor

See#122602

@hroncok
Copy link
ContributorAuthor

Thanks for the second approval@brandtbucher. Could you please merge this as well?

@brandtbucherbrandtbucher merged commit44659d3 intopython:mainAug 5, 2024
@miss-islington-app
Copy link

Thanks@hroncok for the PR, and@brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 5, 2024
…0690)(cherry picked from commit44659d3)Co-authored-by: Miro Hrončok <miro@hroncok.cz>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

GH-122709 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 5, 2024
@hroncokhroncok deleted the jitmakerace branchAugust 5, 2024 23:20
@hroncok
Copy link
ContributorAuthor

Thanks.

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull requestAug 7, 2024
…0690)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
blhsing pushed a commit to blhsing/cpython that referenced this pull requestAug 22, 2024
…0690)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

@brandtbucherbrandtbucher

Labels

buildThe build process and cross-buildtopic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hroncok@brandtbucher@Eclips4@Yhg1s
[8]ページ先頭
©2009-2025 Movatter.jp