Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118948: add support for ISO 8601 basic format todatetime#120553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
picnixz wants to merge15 commits intopython:main
base:main
Choose a base branch
Loading
frompicnixz:basic-iso-date

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedJun 15, 2024•
edited
Loading

In addition todate anddatetime,datetime.time also supports ISO 8601 basic format (the rationale is to make it consistent).

📚 Documentation preview 📚:https://cpython-previews--120553.org.readthedocs.build/

mohd-akram reacted with thumbs up emoji
@ericsnowcurrentlyericsnowcurrently removed their request for reviewJune 17, 2024 19:27
@picnixzpicnixz added the staleStale PR or inactive for long period of time. labelJan 23, 2025
Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It needs some polishing and simplification in my opinion, especially tests, but looks very good in general :-)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess we can leave refactoring for later. LGTM :-)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nineteendonineteendonineteendo left review comments

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Assignees
No one assigned
Labels
awaiting core reviewstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@picnixz@nineteendo@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp