Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-120495: Fix incorrect exception handling in Tab Nanny#120498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Library/2024-06-14-20-05-25.gh-issue-120495.OxgZKB.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Please check the test failure: |
Before, the indentation test exceptSyntaxErrorasmsg:errprint("%r: Token Error: %s"% (file,msg))return But now, it's hitting the correct one: exceptIndentationErrorasmsg:errprint("%r: Indentation Error: %s"% (file,msg))return So we need to fix the test to look for the correct "Indentation Error" text. Please could you update the test? |
I need to change thehttps://github.com/python/cpython/blob/main/Lib/test/test_tabnanny.py#L318-L319 ? |
That's right, change "Token Error" to "Indentation Error" :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
Thanks@Wulian233 for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…nGH-120498)(cherry picked from commitc501261)Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…nGH-120498)(cherry picked from commitc501261)Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-120548 is a backport of this pull request to the3.13 branch. |
GH-120549 is a backport of this pull request to the3.12 branch. |
…n#120498)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…n#120498)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…n#120498)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
See issue, need backport to 3.13?