Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-120367: fix removal of redundant NOPs and jumps after reordering hot-cold blocks#120425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 2 commits intopython:mainfromiritkatriel:gh-120367
Jun 17, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJun 12, 2024•
edited by bedevere-appbot
Loading

@iritkatrieliritkatriel added interpreter-core(Objects, Python, Grammar, and Parser dirs) needs backport to 3.13bugs and security fixes labelsJun 12, 2024
@iritkatrieliritkatriel added the type-crashA hard crash of the interpreter, possibly with a core dump labelJun 12, 2024
@iritkatrieliritkatriel requested a review fromcarljmJune 12, 2024 21:07
Comment on lines +522 to +526
ifhasattr(node,"lineno"):
delnode.lineno
delnode.end_lineno
delnode.col_offset
delnode.end_col_offset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why is it important for this test to remove node locations and then useast.fix_missing_locations? maybe worth a comment?

@iritkatrieliritkatrielenabled auto-merge (squash)June 17, 2024 09:45
@iritkatrieliritkatriel merged commit21866c8 intopython:mainJun 17, 2024
@miss-islington-app
Copy link

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 17, 2024
…ring hot-cold blocks (pythonGH-120425)(cherry picked from commit21866c8)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

GH-120621 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJun 17, 2024
iritkatriel added a commit that referenced this pull requestJun 17, 2024
…ering hot-cold blocks (GH-120425) (#120621)gh-120367: fix removal of redundant NOPs and jumps after reordering hot-cold blocks (GH-120425)(cherry picked from commit21866c8)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatrieliritkatriel added type-bugAn unexpected behavior, bug, or error and removed type-crashA hard crash of the interpreter, possibly with a core dump labelsJun 18, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull requestJun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

no_redundant_jumps: Assertion `0' failed

2 participants

@iritkatriel@carljm
[8]ページ先頭
©2009-2025 Movatter.jp