Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-120170: Exclude __mp_main__ in C version of whichmodule()#120171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromli-dan:fix_120170
May 23, 2025

Conversation

li-dan
Copy link
Contributor

@li-danli-dan commentedJun 6, 2024
edited by bedevere-appbot
Loading

Importing multiprocessing adds an alias to__main__ named__mp_main__. In#23403, the Python version of whichmodule() was fixed to exclude__mp_main__. Apply the same fix to the C version of the function.

@ghost
Copy link

ghost commentedJun 6, 2024
edited by ghost
Loading

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@li-dan
Copy link
ContributorAuthor

With respect to the CLA, I am making this contribution on behalf of my organization, D. E. Shaw & Co., L.P. In 2018 we signed a CLA associated with the bugs.python.org usernamekatz.

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR@li-dan! I'm going to approve this, since it seems straightforward enough. However, it'd be best if someone else was to give it a quick look.

Also, should@li-dan re-sign the CLA? What's the process here? cc@ambv

Importing multiprocessing adds an alias to __main__ named __mp_main__.Inpython#23403, the Python version of whichmodule() was fixed to exclude__mp_main__. Apply the same fix to the C version of the function.
@lysnikolaou
Copy link
Member

@li-dan You'll need to sign the CLA individually as well.

@li-dan
Copy link
ContributorAuthor

Thanks for taking a look at this,@lysnikolaou.

Is there any documentation on the CLA policy? My organization is making this contribution and holds rights to the contribution, so it doesn't seem correct that I should be involved in the licensing process as an individual.

@lysnikolaou
Copy link
Member

I'm not sure what the correct thing to do here is.@ambv You probably know best. Could you please address@li-dan's concerns?

@python-cla-bot
Copy link

python-cla-botbot commentedApr 6, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk
Copy link
Member

@li-dan With the current CLA setup you'll also need to sign an individual CLA. Please could you do that?

See alsohttps://www.python.org/psf/contrib/ which says "The PSF is now asking all past and future contributors to sign a Contributor Agreement."

Thank you.

@li-dan
Copy link
ContributorAuthor

I'm happy to sign the CLA in my personal capacity, but it would not be able to apply to this PR. My organization is licensing this contribution, and as an individual, I do not have rights to grant a license to the contribution. Is that okay?

@pythonpython deleted a commentApr 8, 2025
@ambv
Copy link
Contributor

ambv commentedApr 8, 2025

@li-dan

Yes, this is okay.

We are not aware of the geographical jurisdiction of each particular company and employee. We are also not privy to their particular contract and details about the form of their collaboration. Laws differ between all those cases. Therefore, we always require individual CLAs.

In the case where a blanket organizational CLA already covers a company, and the copyright of a PR is already legally assigned to the company, this is a no-op legally. Such a contributor isn't granting any additional licenses that weren't already granted. But even in this case, it allows Python to track which employees are contributors. It also covers the case where a contributor deliberately or otherwise uses a private email address when authoring their commits.

@li-dan
Copy link
ContributorAuthor

Thanks for the background,@ambv. I am consulting with my employer on how we want to proceed.

@li-dan
Copy link
ContributorAuthor

I have signed the individual CLA.

@hugovkhugovk merged commit05a19b5 intopython:mainMay 23, 2025
42 checks passed
@hugovk
Copy link
Member

Thank you!

@lysnikolaou Does this need backporting?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@li-dan@lysnikolaou@hugovk@ambv

[8]ページ先頭

©2009-2025 Movatter.jp