Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-120057: Add os.environ.refresh() method#120059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I rebased the PR to fix a merge conflict. I addressed@eryksun's and@JelleZijlstra's reviews: thanks! |
Uh oh!
There was an error while loading.Please reload this page.
@serhiy-storchaka@erlend-aasland: Would you mind to review this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What aboutos.environb.refresh()? Does it exist? Does it work?
Uh oh!
There was an error while loading.Please reload this page.
@serhiy-storchaka: I addressed your review. Would you mind to review my updated PR?
I added a test on os.environb.refresh(). Yes, it works as expected :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldos.environb.refresh() be documented? We perhaps do not want to attract too much attention to it, as its effect is the same as ofos.environ.refresh().
Uh oh!
There was an error while loading.Please reload this page.
Test: use directly os.putenv().
Hum, I prefer to not document it athttps://docs.python.org/dev/library/os.html#os.environb :-) |
(Ooops, I closed on [Close] instead of [Comment], sorry.) |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
* Test os.unsetenv()* Document os.unsetenv()* Minor refactoring
@serhiy-storchaka: PR updated for os.unsetenv(). Oh, I didn't know that Python has two functions (putenv, unsetenv) which modify directly the environment without updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Uh oh!
There was an error while loading.Please reload this page.
| to the environment made after this time are not reflected in:data:`os.environ`, | ||
| except for changes made by modifying:data:`os.environ` directly. | ||
| The:meth:`!os.environ.refresh()` method updates:data:`os.environ` with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FTR, the:meth: and:func: roles will implicitly add parentheses in the rendered output; you do not need to add them explicitly.
…)"This reverts commit7aff2de.The function is controversial and it was decided to remove it.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--120059.org.readthedocs.build/