Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
gh-65454: avoid triggering call to a PropertyMock in NonCallableMock.__setattr__#120019
Merged
cjw296 merged 3 commits intopython:mainfromJun 11, 2024
Merged
Conversation
cjw296 approved these changesJun 8, 2024
Contributor
cjw296 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Do you consider this a bugfix or a feature improvement?
ContributorAuthor
blhsing commentedJun 10, 2024
Thanks. I believe this is a bug (it was filed as one) since it should be expected that a |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 11, 2024
…eMock.__setattr__ (pythonGH-120019)(cherry picked from commit9e9ee50)Co-authored-by: blhsing <blhsing@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 11, 2024
…eMock.__setattr__ (pythonGH-120019)(cherry picked from commit9e9ee50)Co-authored-by: blhsing <blhsing@gmail.com>
GH-120336 is a backport of this pull request to the3.13 branch. |
GH-120337 is a backport of this pull request to the3.12 branch. |
cjw296 pushed a commit that referenced this pull requestJun 11, 2024
cjw296 pushed a commit that referenced this pull requestJun 11, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull requestJun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Avoid triggering call to a
PropertyMockinNonCallableMock.__setattr__Previously attaching a
PropertyMockto a mock object would trigger a call to the property mock due to a recursive__setattr__call.This is now fixed by setting the given property mock as an attribute of the hosting mock directly in its
__dict__instead.