Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
bpo-29524: Add Objects/call.c file#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Move all functions to call objects in a new Objects/call.c file.* Rename fast_function() to _PyFunction_FastCallKeywords().* Copy null_error() from Objects/abstract.c* Inline type_error() in call.c to not have to copy it, it was only called once.* Export _PyEval_EvalCodeWithName() since it is now called from call.c.
methane requested changesFeb 11, 2017
| inlines the most primitive frame setup code from | ||
| PyEval_EvalCodeEx(), which vastly reduces the checks that must be | ||
| done before evaluating the frame. | ||
| */ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This comment block should be moved tofunction_code_fastcall().
MemberAuthor
vstinner commentedFeb 11, 2017 via email
Oh in fact it was a deliberate choice to remove the comment. Python 3.7 nowhas a wide range of "fast call" functions which are designed for bestperformance. Do you think that it's worth it to keep the comment? |
methane approved these changesFeb 12, 2017
Member
methane left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just checked all code is moved as-is.
I agree the comment block is not so important.
MemberAuthor
vstinner commentedFeb 12, 2017 via email
Thank you for the review. |
Closed
Contributor
jdemeyer commentedJun 25, 2018
Follow-up at#7909 |
paulmon added a commit to paulmon/cpython that referenced this pull requestJan 10, 2019
Windows arm32 - fix failing tests or skip
emmatyping added a commit to emmatyping/cpython that referenced this pull requestMar 16, 2020
isidentical referenced this pull request in isidentical/cpythonJun 29, 2021
* Handle lines with multi-byte unicode characters properly* Use Py_XDECREF instead of Py_DECREFCo-authored-by: Batuhan Taskaya <isidentical@gmail.com>Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
jaraco pushed a commit that referenced this pull requestDec 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 14, 2024
…PyFuture refcycles (pythonGH-12… (pythonGH-125476)Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pythonGH-124959)"This reverts commitd5dbbf4.(cherry picked from commite99650b)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
This was referencedFeb 11, 2025
dg-pb pushed a commit to dg-pb/cpython that referenced this pull requestOct 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
http://bugs.python.org/issue29524