NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-119826:`ntpath.abspath()` always return absolute path#119938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

zooba merged 13 commits intopython:mainfromnineteendo:fix-ntpath.abspath-2

Nov 12, 2024

Merged

gh-119826:`ntpath.abspath()` always return absolute path#119938

zooba merged 13 commits intopython:mainfromnineteendo:fix-ntpath.abspath-2

Nov 12, 2024

Conversation

Copy link

Contributor

nineteendo commentedJun 2, 2024•
edited by bedevere-appbot
Loading

Issue:ntpath.abspath() always return absolute path #119826

ntpath.abspath() always return absolute path

df0b37f

bedevere-appbot mentioned this pull request

Jun 2, 2024

ntpath.abspath() always return absolute path#119826

Closed

📜🤖 Added by blurb_it.

53b3e41

nineteendo marked this pull request as ready for review

June 2, 2024 11:54

bedevere-appbot added the awaiting review label

Jun 2, 2024

eryksun reviewed

Jun 2, 2024

View reviewed changes

Lib/ntpath.py OutdatedShow resolvedHide resolved

eryksun reviewed

Jun 2, 2024

View reviewed changes

Lib/ntpath.py OutdatedShow resolvedHide resolved

nineteendoand others added2 commits

June 2, 2024 14:27

Update Lib/ntpath.py

4a26721

Co-authored-by: Eryk Sun <eryksun@gmail.com>

Update Lib/ntpath.py

d2b45fe

Co-authored-by: Eryk Sun <eryksun@gmail.com>

eryksun reviewed

Jun 2, 2024

View reviewed changes

Lib/ntpath.pyShow resolvedHide resolved

nineteendo added5 commits

June 2, 2024 23:14

Test for correct sep

340cc07

Revert "Test for correct sep"

abdb8d8

This reverts commit340cc07.

Revert "Revert "Test for correct sep""

f46b0cc

This reverts commitabdb8d8.

Stricter test

6790a15

Fix test

68bb224

eryksun reviewed

Jun 3, 2024

View reviewed changes

Lib/ntpath.py OutdatedShow resolvedHide resolved

nineteendoand others added3 commits

June 3, 2024 08:34

Update Lib/ntpath.py

bcc160e

Co-authored-by: Eryk Sun <eryksun@gmail.com>

Store reference to function

b769371

Rename 2024-06-02-11-48-19.gh-issue-119826.N1obGa.rst to 2024-06-02-1…

9581f83

…1-48-19.gh-issue-119826.N1obGa.rst

Copy link

ContributorAuthor

nineteendo commentedOct 8, 2024

cc@zooba

Merge branch 'main' into fix-ntpath.abspath-2

c68f49e

zoobaenabled auto-merge (squash)

November 12, 2024 20:45

Copy link

Member

zooba commentedNov 12, 2024

Thanks for the contribution! Apologies for taking so long to get to it.

zooba merged commit4b00aba intopython:main

Nov 12, 2024

36 checks passed

bedevere-appbot removed the awaiting review label

Nov 12, 2024

nineteendo deleted the fix-ntpath.abspath-2 branch

November 13, 2024 06:00

Copy link

ContributorAuthor

nineteendo commentedNov 13, 2024

Do we backport this?

Copy link

Contributor

erlend-aasland commentedNov 13, 2024

Do we backport this?

The issue is marked withtype-feature; we do not backport features.

Copy link

ContributorAuthor

nineteendo commentedNov 13, 2024•
edited
Loading

The issue should probably be split up in 3:

normpath('C:.'): bug for relative paths
abspath('C:\x00'): always return absolute path
abspath('./con'): support qualified referencing

The third counts as a feature, but I'm not sure about the first two.

zooba added the needs backport to 3.12only security fixes label

Dec 2, 2024

zooba added the needs backport to 3.13bugs and security fixes label

Dec 2, 2024

Copy link

miss-islington-appbot commentedDec 2, 2024

Thanks@nineteendo for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Copy link

miss-islington-appbot commentedDec 2, 2024

Thanks@nineteendo for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 2, 2024

pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…

c190efe

…ythonGH-119938)(cherry picked from commit4b00aba)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 2, 2024

pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…

ff50ec2

…ythonGH-119938)(cherry picked from commit4b00aba)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

Copy link

bedevere-appbot commentedDec 2, 2024

GH-127534 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Dec 2, 2024

Copy link

bedevere-appbot commentedDec 2, 2024

GH-127535 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

Dec 2, 2024

Copy link

Member

This part of the change is only a bugfix, and only affects currently invalid results, so it's fine to backport. Other PRs attached to the same issue might be considered features (or at least too invasive to backport).

zooba pushed a commit that referenced this pull request

Dec 2, 2024

gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)

af2d24b

(cherry picked from commit4b00aba)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

zooba pushed a commit that referenced this pull request

Dec 2, 2024

gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)

a853610

(cherry picked from commit4b00aba)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Dec 8, 2024

pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…

c10dece

…ythonGH-119938)

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request

Jan 12, 2025

pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…

6713633

…ythonGH-119938)

Labels

None yet

Movatterモバイル変換

Uh oh!

gh-119826:ntpath.abspath() always return absolute path#119938

gh-119826:ntpath.abspath() always return absolute path#119938

Uh oh!

Conversation

nineteendo commentedJun 2, 2024• edited by bedevere-appbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nineteendo commentedOct 8, 2024

Uh oh!

zooba commentedNov 12, 2024

Uh oh!

Uh oh!

nineteendo commentedNov 13, 2024

Uh oh!

erlend-aasland commentedNov 13, 2024

Uh oh!

nineteendo commentedNov 13, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

miss-islington-appbot commentedDec 2, 2024

Uh oh!

miss-islington-appbot commentedDec 2, 2024

Uh oh!

bedevere-appbot commentedDec 2, 2024

Uh oh!

bedevere-appbot commentedDec 2, 2024

Uh oh!

zooba commentedDec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-119826:`ntpath.abspath()` always return absolute path#119938

gh-119826:`ntpath.abspath()` always return absolute path#119938

nineteendo commentedJun 2, 2024•
edited by bedevere-appbot
Loading

nineteendo commentedNov 13, 2024•
edited
Loading