Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-118934: Fix PyEval_GetLocals docs (PEP 667)#119932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ncoghlan merged 4 commits intopython:mainfromncoghlan:gh-118934-fix-pyeval_getlocals-docsJun 2, 2024
Merged
gh-118934: Fix PyEval_GetLocals docs (PEP 667)#119932
ncoghlan merged 4 commits intopython:mainfromncoghlan:gh-118934-fix-pyeval_getlocals-docsJun 2, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
PEP 667's description of the planned changes to PyEval_GetLocalswas internally inconsistent when accepted, so the docs added forpythongh-74929 didn't match either the current behaviour or the intendedbehaviour oncepythongh-118934 is fixed.This PR updates the documentation and 3.13 What's New to match theintended behaviour (oncepythongh-118934 is fixed).
ContributorAuthor
ncoghlan commentedJun 2, 2024
Set to auto-merge, since I don't want to risk the currently incorrect docs making their way into beta2 this week. |
Thanks@ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry,@ncoghlan, I could not cleanly backport this to |
Thanks@ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 2, 2024
PEP 667's description of the planned changes to PyEval_GetLocalswas internally inconsistent when accepted, so the docs added forpythongh-74929 didn't match either the current behaviour or the intendedbehaviour oncepythongh-118934 is fixed.This PR updates the documentation and 3.13 What's New to match theintended behaviour (oncepythongh-118934 is fixed).It also tidies up lingering references to `f_locals` always being adictionary (this hasn't been true since at least when customnamespace support for class statement execution was added)(cherry picked from commitfd6cd62)Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
GH-119934 is a backport of this pull request to the3.13 branch. |
ContributorAuthor
ncoghlan commentedJun 2, 2024
Conflict was due to my failure to merge#119894 yesterday. Fixed that, and retriggered miss-islington |
barneygale pushed a commit to barneygale/cpython that referenced this pull requestJun 5, 2024
PEP 667's description of the planned changes to PyEval_GetLocalswas internally inconsistent when accepted, so the docs added forpythongh-74929 didn't match either the current behaviour or the intendedbehaviour oncepythongh-118934 is fixed.This PR updates the documentation and 3.13 What's New to match theintended behaviour (oncepythongh-118934 is fixed).It also tidies up lingering references to `f_locals` always being adictionary (this hasn't been true since at least when customnamespace support for class statement execution was added)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
PEP 667's description of the planned changes to PyEval_GetLocalswas internally inconsistent when accepted, so the docs added forpythongh-74929 didn't match either the current behaviour or the intendedbehaviour oncepythongh-118934 is fixed.This PR updates the documentation and 3.13 What's New to match theintended behaviour (oncepythongh-118934 is fixed).It also tidies up lingering references to `f_locals` always being adictionary (this hasn't been true since at least when customnamespace support for class statement execution was added)
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
PEP 667's description of the planned changes to PyEval_GetLocalswas internally inconsistent when accepted, so the docs added forpythongh-74929 didn't match either the current behaviour or the intendedbehaviour oncepythongh-118934 is fixed.This PR updates the documentation and 3.13 What's New to match theintended behaviour (oncepythongh-118934 is fixed).It also tidies up lingering references to `f_locals` always being adictionary (this hasn't been true since at least when customnamespace support for class statement execution was added)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added forgh-74929 didn't match either the current behaviour or the intended behaviour oncegh-118934 is fixed.
This PR updates the documentation and 3.13 What's New to match the intended behaviour (oncegh-118934 is fixed).
📚 Documentation preview 📚:https://cpython-previews--119932.org.readthedocs.build/