NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.13] gh-119585: Fix crash involving`PyGILState_Release()` and`PyThreadState_Clear()` (GH-119753)#119859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-bcc1be3-3.13

May 31, 2024

Merged

[3.13] gh-119585: Fix crash involving`PyGILState_Release()` and`PyThreadState_Clear()` (GH-119753)#119859

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-bcc1be3-3.13

May 31, 2024

Conversation

Copy link

Contributor

miss-islington commentedMay 31, 2024•
edited by bedevere-appbot
Loading

Make sure thatgilstate_counter is not zero in when calling
PyThreadState_Clear(). A destructor called fromPyThreadState_Clear() may
call back intoPyGILState_Ensure() andPyGILState_Release(). If
gilstate_counter is zero, it will try to create a new thread state before
the current active thread state is destroyed, leading to an assertion failure
or crash.
(cherry picked from commitbcc1be3)

Co-authored-by: Sam Grosscolesbury@gmail.com

Issue:Crash in freethreading when acquiring/releasing the GIL in a finalizer #119585

pythongh-119585: Fix crash involvingPyGILState_Release()and `PyTh…

97b4a3b

…readState_Clear()` (pythonGH-119753)Make sure that `gilstate_counter` is not zero in when calling`PyThreadState_Clear()`. A destructor called from `PyThreadState_Clear()` maycall back into `PyGILState_Ensure()` and `PyGILState_Release()`. If`gilstate_counter` is zero, it will try to create a new thread state beforethe current active thread state is destroyed, leading to an assertion failureor crash.(cherry picked from commitbcc1be3)Co-authored-by: Sam Gross <colesbury@gmail.com>