Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111201: Skip pyrepl Windows tests earlier#119848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:pyrepl_testwin
May 31, 2024

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 31, 2024•
edited
Loading

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.

@bedevere-appbedevere-appbot added testsTests in the Lib/test dir awaiting core review labelsMay 31, 2024
@bedevere-appbedevere-appbot mentioned this pull requestMay 31, 2024
7 tasks
@vstinnervstinner changed the titlegh-111201: Skip pyperl Windows tests earliergh-111201: Skip pyrepl Windows tests earlierMay 31, 2024
@vstinner
Copy link
MemberAuthor

Example of failiure on FreeBSD where _ctypes extension is missing:https://buildbot.python.org/all/#/builders/1232/builds/2462

0:10:59 load avg: 3.41 [403/478/1] test_pyrepl failed (uncaught exception)Failed to import test module: test.test_pyrepl.test_windows_consoleTraceback (most recent call last):  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 396, in _find_test_path    module = self._get_module_from_name(name)  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 339, in _get_module_from_name    __import__(name)    ~~~~~~~~~~^^^^^^  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_pyrepl/test_windows_console.py", line 5, in <module>    from _pyrepl.windows_console import (    ...<5 lines>...    )  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/_pyrepl/windows_console.py", line 30, in <module>    import ctypes  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/ctypes/__init__.py", line 8, in <module>    from _ctypes import Union, Structure, ArrayModuleNotFoundError: No module named '_ctypes'test test_pyrepl crashed -- Traceback (most recent call last):  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 181, in _runtest_env_changed_exc    _load_run_test(result, runtests)    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 138, in _load_run_test    regrtest_runner(result, test_func, runtests)    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 91, in regrtest_runner    test_result = test_func()  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 135, in test_func    return run_unittest(test_mod)  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 35, in run_unittest    raise Exception("errors while loading tests")Exception: errors while loading tests

Don't attempt to load pyrepl Windows console if platforms others thanWindows. For example, the import can fail if ctypes is missing.
@vstinnervstinnerenabled auto-merge (squash)May 31, 2024 13:50
@vstinnervstinner merged commit91601a5 intopython:mainMay 31, 2024
@vstinnervstinner deleted the pyrepl_testwin branchMay 31, 2024 14:06
@AlexWaygood
Copy link
Member

FYI, I think that that buildbot failure was already fixed an hour ago, in#119834

vstinner reacted with eyes emoji

vstinner added a commit to vstinner/cpython that referenced this pull requestJun 1, 2024
Don't attempt to load pyrepl Windows console if platforms others thanWindows. For example, the import can fail if ctypes is missing.(cherry picked from commit91601a5)
@bedevere-app
Copy link

GH-119924 is a backport of this pull request to the3.13 branch.

vstinner added a commit that referenced this pull requestJun 1, 2024
gh-111201: Skip pyrepl Windows tests earlier (#119848)Don't attempt to load pyrepl Windows console if platforms others thanWindows. For example, the import can fail if ctypes is missing.(cherry picked from commit91601a5)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
Don't attempt to load pyrepl Windows console if platforms others thanWindows. For example, the import can fail if ctypes is missing.
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Don't attempt to load pyrepl Windows console if platforms others thanWindows. For example, the import can fail if ctypes is missing.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@AlexWaygood@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp