Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-119127: functools.partial placeholders#119827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
78 commits Select commitHold shift + click to select a range
ee7333c Initial Implementation
dg-pb8bcc462 serialization fix
dg-pbc67c9b4 bug fix
dg-pb680d900 Bug 2 fix
dg-pb9591ff5 Py_TPFLAGS_IMMUTABLETYPE added
dg-pb067e938 placeholder added to state as opposed to being used as global constant
dg-pb8af20b3 static removed
dg-pb607a0b1 creating sentinel via PyType_Spec
dg-pbf55801e more accurate variable name
dg-pb5894145 trailing trim bug and tests
dg-pb3722e07 Updated docs
dg-pba79c2af blurb
dg-pb12aaa72 Merge branch 'main' into implement-119127
92c767b minor edit
dg-pb496a9d2 doc fix
dg-pb38d9c11 better variable names and mini corrections
dg-pb707b957 Merge branch 'implement-119127' into implement-119127-again
dg-pb14b38ca review comments mostly
dg-pb32bca19 singleton sentinel and reduce
dg-pb8576493 python module sentinel better mimics the one of the extension
dg-pba3fd2d6 Emulated None behaviour, but using PyType_FromModuleAndSpec
dg-pb0852993 review feedback
dg-pb6fea348 included constant into tsv
dg-pbcaec6e8 documentation update
dg-pb115b8c5 review edits
dg-pb3f5f00b trailing placeholder prohibition and small changes
dg-pb202c929 change constant name in ignores
dg-pb2c16d38 PlaceholderType Hidden
dg-pb400ff55 support 4-arg pre-placeholder state
dg-pb8ccc38f better variable names
dg-pbe7c82c7 partialmethod impl
dg-pbc9b7ef3 fix tests
dg-pbe59d711 adjust inspect to partial Placeholders
dg-pb7bfc591 arg alignment
dg-pb7957a97 small fixes
dg-pb8aaee6a pickle compatibility ensured
dg-pbfe8e0ad trailing placeholder test for __setstate__
dg-pb00dd80e rough implementation rolled back and example of successive applicatio…
dg-pbd352cfa small doc edits
dg-pb9038ed5 example changes
dg-pb49b8c71 serialization issues addressed
dg-pbbc1fdbd delete redundant references
dg-pb3067221 simplify PyPlaceholder implementation
dg-pb1185510 more optimal python functools.partial
dg-pb266b4fa placeholder arg and pre-placeholder instance conversions to positional
dg-pbdd58a12 unittest.mock.ANY test for Placeholder
dg-pb5971fbb functools.partial.__get__
dg-pb9033650 Revert "functools.partial.__get__"
dg-pbd31e5d1 Merge branch 'main' into implement-119127-again
dg-pba3d39b0 review changes
dg-pb9e4c5df factor out repr. same to be used for partial and partialmethod
dg-pb16f12f8 microopt & args.count(Placeholder) can not be used as it uses __eq__
dg-pb82dd600 simplify preparation
dg-pbf9cb653 whatsnew + minor doc edit
dg-pbd255524 typo fixes
dg-pb404044e whatsnew edit
dg-pb800217b revert stylistic changes
dg-pb38ee450 factor out full __new__
dg-pb11f47db Merge branch 'main' into implement-119127-again
serhiy-storchaka3c872bd Merge branch 'main' into implement-119127-again
serhiy-storchakafd16189 CR part 1
dg-pba6c6ef2 CR Part 2
dg-pb1c8d73e remove ignored global var
dg-pba8bd3ae CR changes
dg-pb70e47ed small CR changes and doc updates
dg-pb2eacf5e push placeholder check to earlier place
dg-pbf78d8d3 more appropriate test functions and better doc example
dg-pb0a8640e minor fixes; message, doc polish
dg-pb6e3d282 better doc example and small test changes
dg-pb66c305d assertRaisesRegex exact match
dg-pb14bf68c doc nits
dg-pbee642d5 Add Placeholder to __all__
rhettinger8d6c28e Update copyright span
rhettinger8744bcb Minor doc edits and add doctests
rhettingerb896470 Merge branch 'main' into implement-119127-again
rhettinger4881ae6 Merge branch 'main' into implement-119127-again
rhettingerc3ad7d9 Having the separate dict was necessary to eliminate duplicate keywords
rhettinger5e5d484 Merge branch 'main' into implement-119127-again
rhettingerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
singleton sentinel and reduce
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit32bca19f046dae46a5a2a157fa991d45e58e4acf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -333,7 +333,7 @@ def __call__(self, /, *args, **keywords): | ||
| if len(args) < placeholder_count: | ||
dg-pb marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| raise TypeError( | ||
| "missing positional arguments in 'partial' call; expected " | ||
| f"at least {placeholder_count}, got {len(args)}") | ||
| f_args = list(self.args) | ||
| j, pos = 0, 0 | ||
| while j < placeholder_count: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -43,27 +43,118 @@ get_functools_state(PyObject *module) | ||
| /* partial object **********************************************************/ | ||
| /* | ||
| Placeholder is an object that can be used to signal that positional | ||
| argument place is empty when using `partial` class | ||
| */ | ||
dg-pb marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| PyObject* | ||
| Py_GetPlaceholder(void); | ||
| static PyObject * | ||
| placeholder_repr(PyObject *op) | ||
| { | ||
| return PyUnicode_FromString("Placeholder"); | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Maybe use In particular, you could also decide whether the singleton should be implemented (and exported) using the same logic as for (Sorry, I only remembered about that singleton now and not before) | ||
| } | ||
| static void | ||
| placeholder_dealloc(PyObject* placeholder) | ||
| { | ||
| /* This should never get called, but we also don't want to SEGV if | ||
| * we accidentally decref None out of existence. Instead, | ||
| * since None is an immortal object, re-set the reference count. | ||
dg-pb marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| */ | ||
| _Py_SetImmortal(placeholder); | ||
| } | ||
| static PyObject * | ||
| placeholder_new(PyTypeObject *type, PyObject *args, PyObject *kwargs) | ||
| { | ||
| if (PyTuple_GET_SIZE(args) || (kwargs && PyDict_GET_SIZE(kwargs))) { | ||
| PyErr_SetString(PyExc_TypeError, "PlaceholderType takes no arguments"); | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. You could use | ||
| return NULL; | ||
| } | ||
| return Py_GetPlaceholder(); | ||
| } | ||
| static int | ||
| placeholder_bool(PyObject *v) | ||
| { | ||
| PyErr_SetString(PyExc_TypeError, | ||
| "Placeholder should not be used in a boolean context"); | ||
| return -1; | ||
| } | ||
| static PyNumberMethods placeholder_as_number = { | ||
| .nb_bool = placeholder_bool, | ||
| }; | ||
| PyDoc_STRVAR(placeholder_doc, | ||
| "PlaceholderType()\n" | ||
| "--\n\n" | ||
| "The type of the Placeholder singleton."); | ||
| PyTypeObject _PyPlaceholder_Type = { | ||
| PyVarObject_HEAD_INIT(&PyType_Type, 0) | ||
| "PlaceholderType", | ||
| 0, | ||
| 0, | ||
| placeholder_dealloc, /*tp_dealloc*/ /*never called*/ | ||
| 0, /*tp_vectorcall_offset*/ | ||
| 0, /*tp_getattr*/ | ||
| 0, /*tp_setattr*/ | ||
| 0, /*tp_as_async*/ | ||
| placeholder_repr, /*tp_repr*/ | ||
| &placeholder_as_number, /*tp_as_number*/ | ||
| 0, /*tp_as_sequence*/ | ||
| 0, /*tp_as_mapping*/ | ||
| 0, /*tp_hash */ | ||
| 0, /*tp_call */ | ||
| 0, /*tp_str */ | ||
| 0, /*tp_getattro */ | ||
| 0, /*tp_setattro */ | ||
| 0, /*tp_as_buffer */ | ||
| Py_TPFLAGS_DEFAULT, /*tp_flags */ | ||
| placeholder_doc, /*tp_doc */ | ||
| 0, /*tp_traverse */ | ||
| 0, /*tp_clear */ | ||
| 0, /*tp_richcompare */ | ||
| 0, /*tp_weaklistoffset */ | ||
| 0, /*tp_iter */ | ||
| 0, /*tp_iternext */ | ||
| 0, /*tp_methods */ | ||
| 0, /*tp_members */ | ||
| 0, /*tp_getset */ | ||
| 0, /*tp_base */ | ||
| 0, /*tp_dict */ | ||
| 0, /*tp_descr_get */ | ||
| 0, /*tp_descr_set */ | ||
| 0, /*tp_dictoffset */ | ||
| 0, /*tp_init */ | ||
| 0, /*tp_alloc */ | ||
| placeholder_new, /*tp_new */ | ||
| }; | ||
| PyObject _Py_PlaceholderStruct = _PyObject_HEAD_INIT(&_PyPlaceholder_Type); | ||
| #define PY_CONSTANT_PLACEHOLDER 0 | ||
| static PyObject* constants[] = { | ||
| &_Py_PlaceholderStruct, // PY_CONSTANT_PLACEHOLDER | ||
| }; | ||
| PyObject* | ||
| Py_GetPlaceholder(void) | ||
| { | ||
| if (PY_CONSTANT_PLACEHOLDER < Py_ARRAY_LENGTH(constants)) { | ||
| return constants[PY_CONSTANT_PLACEHOLDER]; | ||
| } | ||
| else { | ||
| PyErr_BadInternalCall(); | ||
| return NULL; | ||
| } | ||
| } | ||
| typedef struct { | ||
| @@ -150,7 +241,7 @@ partial_new(PyTypeObject *type, PyObject *args, PyObject *kw) | ||
| return NULL; | ||
| } | ||
| pto->placeholder =Py_GetPlaceholder(); | ||
| Py_ssize_t nnp = 0; | ||
| Py_ssize_t nnargs = PyTuple_GET_SIZE(nargs); | ||
| PyObject *item; | ||
| @@ -598,18 +689,19 @@ partial_repr(partialobject *pto) | ||
| static PyObject * | ||
| partial_reduce(partialobject *pto, PyObject *unused) | ||
| { | ||
| return Py_BuildValue("O(O)(OOOnO)", Py_TYPE(pto), pto->fn, pto->fn, | ||
| pto->args, pto->kw, pto->np, | ||
| pto->dict ? pto->dict : Py_None); | ||
| } | ||
| static PyObject * | ||
| partial_setstate(partialobject *pto, PyObject *state) | ||
| { | ||
| PyObject *fn, *fnargs, *kw, *dict; | ||
| Py_ssize_t np; | ||
| if (!PyTuple_Check(state) || | ||
| !PyArg_ParseTuple(state, "OOOnO", &fn, &fnargs, &kw, &np, &dict) || | ||
| !PyCallable_Check(fn) || | ||
| !PyTuple_Check(fnargs) || | ||
| (kw != Py_None && !PyDict_Check(kw))) | ||
| @@ -640,10 +732,10 @@ partial_setstate(partialobject *pto, PyObject *state) | ||
| dict = NULL; | ||
| else | ||
| Py_INCREF(dict); | ||
| Py_SETREF(pto->fn, Py_NewRef(fn)); | ||
| Py_SETREF(pto->args, fnargs); | ||
| Py_SETREF(pto->kw, kw); | ||
| pto->np = np; | ||
| Py_XSETREF(pto->dict, dict); | ||
| partial_setvectorcall(pto); | ||
| Py_RETURN_NONE; | ||
| @@ -1626,6 +1718,7 @@ static PyType_Spec lru_cache_type_spec = { | ||
| /* module level code ********************************************************/ | ||
dg-pb marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| PyDoc_STRVAR(_functools_doc, | ||
| "Tools that operate on functions."); | ||
| @@ -1644,15 +1737,9 @@ _functools_exec(PyObject *module) | ||
| return -1; | ||
| } | ||
| if (PyModule_AddObject(module, "Placeholder", Py_GetPlaceholder()) < 0) { | ||
| return -1; | ||
| } | ||
| state->partial_type = (PyTypeObject *)PyType_FromModuleAndSpec(module, | ||
| &partial_type_spec, NULL); | ||
| if (state->partial_type == NULL) { | ||
| @@ -1697,7 +1784,6 @@ _functools_traverse(PyObject *module, visitproc visit, void *arg) | ||
| { | ||
| _functools_state *state = get_functools_state(module); | ||
| Py_VISIT(state->kwd_mark); | ||
| Py_VISIT(state->partial_type); | ||
| Py_VISIT(state->keyobject_type); | ||
| Py_VISIT(state->lru_list_elem_type); | ||
| @@ -1709,7 +1795,6 @@ _functools_clear(PyObject *module) | ||
| { | ||
| _functools_state *state = get_functools_state(module); | ||
| Py_CLEAR(state->kwd_mark); | ||
| Py_CLEAR(state->partial_type); | ||
| Py_CLEAR(state->keyobject_type); | ||
| Py_CLEAR(state->lru_list_elem_type); | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.