Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-109218: Refactor tests for the complex() constructor (GH-119635)#119795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedMay 30, 2024•
edited by bedevere-appbot
Loading

  • Share common classes.
  • Use exactly representable floats and exact tests.
  • Check the sign of zero components.
  • Remove duplicated tests (mostly left after merging int and long).
  • Reorder tests in more consistent way.
  • Test more error messages.
  • Add tests for missed cases.
    (cherry picked from commitbf098d4)

Co-authored-by: Serhiy Storchakastorchaka@gmail.com

…GH-119635)* Share common classes.* Use exactly representable floats and exact tests.* Check the sign of zero components.* Remove duplicated tests (mostly left after merging int and long).* Reorder tests in more consistent way.* Test more error messages.* Add tests for missed cases.(cherry picked from commitbf098d4)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hugovkhugovkdisabled auto-mergeAugust 9, 2024 14:04
@hugovk
Copy link
Member

hugovk commentedAug 9, 2024•
edited
Loading

@serhiy-storchaka You enabled auto-merge on this, but for some reason the "Tests / Windows (free-threading) / build (arm64)" CI failed, so it didn't merge.

Unfortunately thelogs have since expired, maybe it was just a temporary thing. I've merged inmain to restart the CI.

I've also disabled auto-merge, because 3.13 is in the RC phase and I'll let you make a fresh decision whether it can be merged now.

serhiy-storchaka reacted with thumbs up emoji

@hugovk
Copy link
Member

CI passed now. I think it probably could go into 3.13, it's only changing test files.

@serhiy-storchakaserhiy-storchaka merged commit013752c intopython:3.13Aug 9, 2024
34 checks passed
@serhiy-storchaka
Copy link
Member

Thank you@hugovk for noticing this.

hugovk reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@miss-islington@hugovk@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp