Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-89727: Fix FD leak onos.fwalk() generator finalization.#119766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@barneygale
Copy link
Contributor

@barneygalebarneygale commentedMay 30, 2024
edited by bedevere-appbot
Loading

Follow-up to3c890b5. Ensure weos.close() open file descriptors when theos.fwalk() generator is finalized.

Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.
@barneygale
Copy link
ContributorAuthor

Skipping news because I only just broke this 🙈

@barneygalebarneygaleenabled auto-merge (squash)May 30, 2024 03:36
@barneygalebarneygale merged commita5fef80 intopython:mainMay 30, 2024
@miss-islington-app
Copy link

Thanks@barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2024
…ythonGH-119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.(cherry picked from commita5fef80)Co-authored-by: Barney Gale <barney.gale@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2024
…ythonGH-119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.(cherry picked from commita5fef80)Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-app
Copy link

GH-119767 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 30, 2024
@bedevere-app
Copy link

GH-119768 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 30, 2024
barneygale added a commit that referenced this pull requestMay 30, 2024
…H-119766) (#119768)GH-89727: Fix FD leak on `os.fwalk()` generator finalization. (GH-119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.(cherry picked from commita5fef80)Co-authored-by: Barney Gale <barney.gale@gmail.com>
barneygale added a commit that referenced this pull requestMay 30, 2024
…H-119766) (#119767)GH-89727: Fix FD leak on `os.fwalk()` generator finalization. (GH-119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.(cherry picked from commita5fef80)Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotwasm32-wasi 3.13 has failed when building commit083bf3a.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1502/builds/100) and take a look at the build logs.
  4. Check if the failure is related to this commit (083bf3a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1502/builds/100

Failed tests:

  • test_statistics

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 11, done.remote:Counting objects:   9% (1/11)remote:Counting objects:  18% (2/11)remote:Counting objects:  27% (3/11)remote:Counting objects:  36% (4/11)remote:Counting objects:  45% (5/11)remote:Counting objects:  54% (6/11)remote:Counting objects:  63% (7/11)remote:Counting objects:  72% (8/11)remote:Counting objects:  81% (9/11)remote:Counting objects:  90% (10/11)remote:Counting objects: 100% (11/11)remote:Counting objects: 100% (11/11), done.remote:Compressing objects: 100% (1/1)remote:Compressing objects: 100% (1/1), done.remote:Total 6 (delta 5), reused 5 (delta 5), pack-reused 0From https://github.com/python/cpython * branch                  3.13       -> FETCH_HEADNote:switching to '083bf3ad1795604ee833d1595f2a536b9cd57419'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 083bf3ad17 [3.13] GH-89727: Fix FD leak on `os.fwalk()` generator finalization. (GH-119766) (#119767)Switched to and reset branch '3.13'configure:WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)configure:WARNING: using cross tools not prefixed with host tripletconfigure:WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.../../Modules/expat/xmlparse.c:7839:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat] 7838 |           " (+" EXPAT_FMT_PTRDIFF_T("6") " bytes %s|%d, xmlparse.c:%d) %*s\"",|~~~~~~~~~~~~~~~~~~~~~~~~ 7839 |           bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",|^~~~~~~~~1 warning generated.../../Modules/_testinternalcapi/test_critical_sections.c:142:1: warning: unused function 'thread_critical_sections' [-Wunused-function]  142 | thread_critical_sections(void *arg)|^~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.../../Modules/posixmodule.c:7859:1: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function] 7859 | warn_about_fork_with_threads(const char* name)|^~~~~~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.Kill <WorkerThread #1 running test=test_statistics pid=134186 time=25 min> process groupmake:*** [Makefile:2210: buildbottest] Error 2Cannot open file '/home/buildbot/buildarea/3.13.bcannon-wasi.wasi.debug/build/build/cross-build/wasm32-wasi/test-results.xml' for upload

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Clang Installed 3.13 has failed when building commit083bf3a.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1392/builds/66) and take a look at the build logs.
  4. Check if the failure is related to this commit (083bf3a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1392/builds/66

Failed tests:

  • test_free_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Note:switching to '083bf3ad1795604ee833d1595f2a536b9cd57419'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 083bf3ad17 [3.13] GH-89727: Fix FD leak on `os.fwalk()` generator finalization. (GH-119766) (#119767)Switched to and reset branch '3.13'configure:WARNING: s390x-ibm-linux-gnu/clang is not supportedconfigure:WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)configure:WARNING:Platform "s390x-ibm-linux-gnu" with compiler "clang" is not supported by theCPython core team, see https://peps.python.org/pep-0011/ for more information.Python/import.c:1619:1: warning: unused function 'is_core_module' [-Wunused-function]is_core_module(PyInterpreterState *interp, PyObject *name, PyObject *path)^1 warning generated.Python/pystate.c:1135:1: warning: unused function 'check_interpreter_whence' [-Wunused-function]check_interpreter_whence(long whence)^1 warning generated.  WARNING: The scripts pip3 and pip3.13 are installed in '/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.clang-installed/build/target/bin' which is not on PATH.  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
…ython#119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…ython#119766)Follow-up to3c890b5. Ensure we `os.close()` open file descriptors whenthe `os.fwalk()` generator is finalized.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barneygale@bedevere-bot@carljm

[8]ページ先頭

©2009-2025 Movatter.jp