Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119740: Remove deprecated trunc delegation#119743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mdickinson
Copy link
Member

@mdickinsonmdickinson commentedMay 29, 2024•
edited
Loading

This PR removes the delegation ofint to the__trunc__ special method:int will now only delegate to__int__ and__index__ (in that order).__trunc__ continues to exist, but its sole purpose is to supportmath.trunc.

📚 Documentation preview 📚:https://cpython-previews--119743.org.readthedocs.build/

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. But I would prefer to merge this after#119687, to make backporting of#119687 easier.

@mdickinson
Copy link
MemberAuthor

Thanks for the comments; I'll address before merging (but it may take me a few days to get to it).

@mdickinson
Copy link
MemberAuthor

But I would prefer to merge this after#119687, to make backporting of#119687 easier.

Definitely! Looks like#119687 has gone in now; I'll update for conflicts when I get the chance.

mdickinsonand others added2 commitsJune 2, 2024 09:34
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@mdickinson
Copy link
MemberAuthor

Updating for merge conflicts ...

@mdickinsonmdickinson merged commitf79ffc8 intopython:mainJun 2, 2024
36 checks passed
barneygale pushed a commit to barneygale/cpython that referenced this pull requestJun 5, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.---------Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.---------Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.---------Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mdickinson@serhiy-storchaka@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp