Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119690: Adds Unicode support for named pipes in _winapi#119717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 2 commits intopython:mainfromzooba:gh-119690
May 29, 2024

Conversation

@zooba
Copy link
Member

@zoobazooba commentedMay 29, 2024•
edited by bedevere-appbot
Loading

This will need backporting further, but it's only getting to 3.12 in this form. I'll do the 3.11 and earlier ports separately.

@zoobazooba added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMay 29, 2024
@zoobazooba requested a review fromeryksunMay 29, 2024 10:08
@zoobazooba self-assigned thisMay 29, 2024
deftest_winapi_createnamedpipe(self):
winapi=import_helper.import_module("_winapi")

pipe_name=r"\\.\pipe\LOCAL\test_winapi_createnamed_pipe"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can the pipe name contain non-ASCII characters?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It can, but the problem being checked here was due to misrepresentingchar * aswchar_t *, and so ASCII is sufficient to turn into corruption when yous.encode('ascii').decode('utf-16-le').

Copy link
Contributor

@eryksuneryksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. 🚀

@zoobazooba merged commit78d697b intopython:mainMay 29, 2024
@miss-islington-app
Copy link

Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 29, 2024
…honGH-119717)(cherry picked from commit78d697b)Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington-app
Copy link

Sorry,@zooba, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 78d697b7d5ec2a6fa046b0e1c34e804f49e750b4 3.12

@bedevere-app
Copy link

GH-119732 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 29, 2024
@zoobazooba deleted the gh-119690 branchMay 29, 2024 15:52
@bedevere-app
Copy link

GH-119733 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 29, 2024
zooba added a commit that referenced this pull requestMay 30, 2024
Also backports a minor improvement to test_audit.
zooba added a commit that referenced this pull requestMay 31, 2024
(cherry picked from commit78d697b)Co-authored-by: Steve Dower <steve.dower@python.org>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@eryksuneryksuneryksun approved these changes

Assignees

@zoobazooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zooba@eryksun@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp