Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-97850: removefind_loader andget_loader frompkgutil#119656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 17 commits intopython:mainfrompicnixz:remove-deprecated-pkgutil
Nov 1, 2024

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedMay 28, 2024
edited by bedevere-appbot
Loading

@picnixzpicnixz changed the titleRemovefind_loader andget_loader frompkgutilgh-#97850: removefind_loader andget_loader frompkgutilMay 28, 2024
@picnixzpicnixz changed the titlegh-#97850: removefind_loader andget_loader frompkgutilgh-97850: removefind_loader andget_loader frompkgutilMay 28, 2024
@picnixzpicnixz changed the titlegh-97850: removefind_loader andget_loader frompkgutil[3.14] gh-97850: removefind_loader andget_loader frompkgutilMay 28, 2024
@picnixz
Copy link
MemberAuthor

Quick question but how do you manage the whatsnews sections when a feature is being removed? I cannot really change it to:func:`!pkgutil.find_loader` since these are available in previous versions.

@picnixzpicnixz changed the title[3.14] gh-97850: removefind_loader andget_loader frompkgutilgh-97850: removefind_loader andget_loader frompkgutilMay 28, 2024
Copy link
Member

@sobolevnsobolevn left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please, update

:func:`pkgutil.find_loader`:func:`pkgutil.get_loader`

to be

:func:`!pkgutil.find_loader`:func:`!pkgutil.get_loader`

Since all python versions have their own versions of3.13.rst /3.12.rst / etc.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@picnixz
Copy link
MemberAuthor

Yes, that's what I was actually asking. Should I just suppressevery possible links in the others 3.x.rst files even though they exist? (if so, I can do it but I wanted to be sure that all references should be suppressedeven for old versions for which the reference would exist).

sobolevn reacted with thumbs up emoji

@sobolevn
Copy link
Member

Again, older versions won't be affected, because they live in their own branches. And we won't backport this change.

picnixz reacted with thumbs up emoji

@picnixz
Copy link
MemberAuthor

Oh yes, it was dumb of me. I incorrectly assumed that the 3.12 page was for the corresponding branch (seems I'm still not entirely awake). Anyway, I have made the requested changes; please review again.

sobolevn reacted with heart emoji

@bedevere-app
Copy link

Thanks for making the requested changes!

@sobolevn: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review fromsobolevnMay 29, 2024 08:17
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I somehow did not send this comment.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

This has a conflict after the#122085 re-org.

@picnixz
Copy link
MemberAuthor

Oh, I forgot about this one :') I'll fix the conflicts err... I don't know when (I'm a bit busy writing something currently and don't know if I'll have tomorrow)

@hugovk
Copy link
Member

Thanks, absolutely no rush with this :)

@Wulian233
Copy link
Contributor

#123036
Need change

@brettcannon
Copy link
Member

@picnixz are you waiting on anything for this? You haven't triggered a request for a re-review.

@picnixz
Copy link
MemberAuthor

Oh I forgot about it. This one is a low-priority task (which is why I didn't re-request a review) and we were waiting for more experts feedback (such as yours I think?) so we can address this issue when people have the time!

(I'll be barely present for the rest of the week)

@hugovk
Copy link
Member

Where are we up to here?

Our friends at Fedora, who do a huge amount of valuable early testing and fixing of Python packages, are asking about pending deprecations for 3.14:

https://discuss.python.org/t/if-you-plan-to-remove-deprecated-apis-from-python-3-14-please-do-it-now/67955

@picnixz
Copy link
MemberAuthor

I always forget about this PR :D We actually waited for an expert on pkgutil to confirm that the removal is ok. Apart from that, I don't think I wanted to do more. I'll ask a round of re-review.

@brettcannon
Copy link
Member

We actually waited for an expert on pkgutil to confirm that the removal is ok

There is no pkgutil expert, hence the deprecation (that and it not plugging into importlib cleanly). 😉

picnixz reacted with laugh emoji

@hugovk
Copy link
Member

Let's merge!

picnixz and brettcannon reacted with hooray emojipicnixz reacted with heart emoji

@hugovkhugovk merged commit464a7a9 intopython:mainNov 1, 2024
36 checks passed
@picnixzpicnixz deleted the remove-deprecated-pkgutil branchNovember 1, 2024 16:39
picnixz added a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
…til`` (python#119656)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Brett Cannon <brett@python.org>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
…til`` (python#119656)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Brett Cannon <brett@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannon

@warsawwarsawAwaiting requested review from warsaw

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@picnixz@sobolevn@warsaw@hugovk@Wulian233@brettcannon

[8]ページ先頭

©2009-2025 Movatter.jp