Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-117398: Add multiphase support to _datetime (gh-119373)#119636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedMay 27, 2024•
edited by bedevere-appbot
Loading

This is minimal support. Subinterpreters are not supported yet. That will be addressed in a later change.

(cherry picked from commit3e8b609)

Co-authored-by: Erlend E. Aaslanderlend@python.org
Co-authored-by: Eric Snowericsnowcurrently@gmail.com

This is minimal support.  Subinterpreters are not supported yet.  That will be addressed in a later change.(cherry picked from commit3e8b609)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently
Copy link
Member

This broke a bunch of the 3.13 buildbots so I'm reverting it for now.

@ericsnowcurrently
Copy link
Member

For example:https://buildbot.python.org/all/#builders/1508/builds/69

test_utc_alias (test.datetimetester.TestModule_Pure.test_utc_alias) ... oktest_utc_alias (test.datetimetester.TestModule_Fast.test_utc_alias) ... FAIL======================================================================FAIL: test_utc_alias (test.datetimetester.TestModule_Fast.test_utc_alias)----------------------------------------------------------------------Traceback (most recent call last):  File "/home/buildbot/buildarea/3.13.cstratak-RHEL7-x86_64/build/Lib/test/datetimetester.py", line 98, in test_utc_alias    self.assertIs(UTC, timezone.utc)    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc----------------------------------------------------------------------Ran 2 tests in 0.007sFAILED (failures=1)test test_datetime failed

@ericsnowcurrently
Copy link
Member

Hmm, looks like I forgot to backportgh-119472.

ericsnowcurrently added a commit that referenced this pull requestMay 28, 2024
…me (#119639)Revert "[3.13]gh-117398: Add multiphase support to _datetime (gh-119373) (gh-119636)"This reverts commitd58ebf0.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull requestMay 28, 2024
ericsnowcurrently added a commit that referenced this pull requestMay 29, 2024
This is an unrevert ofd58ebf0 (gh-119636), which was reverted by 9216a53 (gh-119639) due to problems which have been resolved.This is minimal support for multiphase init. Subinterpreters are not supported yet. That will be addressed in a later change.(cherry picked from commit 3e8b609)Co-authored-by: Erlend E. Aasland erlend@python.org
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@miss-islington@ericsnowcurrently@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp