NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.13] gh-119584: Fix test_import Failed Assertion (gh-119623)#119633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericsnowcurrently merged 1 commit intopython:3.13frommiss-islington:backport-ae7b176-3.13

May 27, 2024

Merged

[3.13] gh-119584: Fix test_import Failed Assertion (gh-119623)#119633

ericsnowcurrently merged 1 commit intopython:3.13frommiss-islington:backport-ae7b176-3.13

May 27, 2024

Conversation

Copy link

Contributor

miss-islington commentedMay 27, 2024•
edited by bedevere-appbot
Loading

The fix ingh-119561 introduced an assertion that doesn't hold true if any of the three new test extension modules are loaded more than once. This is fine normally but breaks if the new test_check_state_first() is run more than once, which happens for refleak checking and with the regrtest --forever flag. We fix that here by clearing each of the three modules after loading them. We also tweak a check in _modules_by_index_check().
(cherry picked from commitae7b176)

Co-authored-by: Eric Snowericsnowcurrently@gmail.com

Issue:test_import crashes with a--forever option #119584

pythongh-119584: Fix test_import Failed Assertion (pythongh-119623)

cf9c610

The fix inpythongh-119561 introduced an assertion that doesn't hold true if any of the three new test extension modules are loaded more than once.  This is fine normally but breaks if the new test_check_state_first() is run more than once, which happens for refleak checking and with the regrtest --forever flag.  We fix that here by clearing each of the three modules after loading them.  We also tweak a check in _modules_by_index_check().(cherry picked from commitae7b176)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>