NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.9] gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix (GH-112771)#119566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ambv merged 1 commit intopython:3.9fromned-deily:gh_112771-39

May 30, 2024

Merged

[3.9] gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix (GH-112771)#119566

ambv merged 1 commit intopython:3.9fromned-deily:gh_112771-39

May 30, 2024

Conversation

Copy link

Member

ned-deily commentedMay 25, 2024•
edited by bedevere-appbot
Loading

zlib-ng defines the version as "1.3.0.zlib-ng".
(cherry picked from commitd384813)

Co-authored-by: Miro Hrončokmiro@hroncok.cz

Issue:test.test_zlib.CompressObjectTestCase.test_flushes fails to parse ZLIB_VERSION with zlib-ng #112769

[3.9]pythongh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_R…

3b9c4b6

…UNTIME_VERSION with non-int suffix (pythonGH-112771)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok miro@hroncok.cz

bedevere-appbot added tests

Tests in the Lib/test dir

awaiting core review labels

May 25, 2024

This was referencedMay 25, 2024

test.test_zlib.CompressObjectTestCase.test_flushes fails to parse ZLIB_VERSION with zlib-ng#112769

Closed

gh-112769: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix#112771

Merged

ned-deily assignedambv

May 25, 2024

encukou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

May 29, 2024

Copy link

bedevere-bot commentedMay 29, 2024

🤖 New build scheduled with the buildbot fleet by@encukou for commit3b9c4b6 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

May 29, 2024

Copy link

Member

encukou commentedMay 30, 2024

@ambv, please merge this test-only change to fix failing 3.9 buildbots.

All failures are expected/unrelated:

zlib-ng on s390x uses hardware acceleration, which outpots in different (but valid) bits than software zlib. That test is adjusted in later CPython versions.
preexisting failures: dbm crashes on macOS GHA, asyncio fails on macOS buildbot
usan/BSD/FIPS/nogil/wasi/iOS/win11-bigmem buildbots aren't applicable/configured/supported for 3.9