Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-111201: Support pyrepl on Windows#119559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
1061d22
fa0f538
6f35100
7772787
aced5ae
fa3815f
b30b105
df262c4
6e57316
18ecc2e
60525eb
af79a17
5f99256
bdff535
88d64f5
8a74306
38e9c58
9cddace
fc4efee
564e6e1
3ae4316
5bb02a2
500761e
98f16b9
911a76a
77f1c42
243817d
25f51b4
5242239
febe424
756ac47
50fd4c9
ff46d66
fbb9f84
683f5f6
2c524b8
44ce57b
5ecc8cd
5bb90c7
35557dd
e04699f
6230400
70a9a31
4adfe77
9c00bd1
dc7ec86
79a3fb9
3e4fe55
38800e7
b3f7092
a589321
9a34d8a
f8a9176
ce77202
6d8e7f5
bbbb296
d064124
f244a0e
3d526ba
b1f5688
1146dbb
972e7ec
1d300e4
d783dae
d1289af
db191a2
fba84aa
42e3e8e
63d854e
513a148
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
import os | ||
import sys | ||
CAN_USE_PYREPL: bool | ||
if sys.platform != "win32": | ||
CAN_USE_PYREPL = True | ||
else: | ||
CAN_USE_PYREPL = sys.getwindowsversion().build >= 10586 # Windows 10 TH2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This merged as-is which is OK, but I wanted to chip in... There is aminimal risk of cutting out terminals that would support pyrepl on earlier versions of Windows. The "most correct" (also most soapboxy, sorry!) way to determine support for this is to just try to set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @DHowett sounds like an improvement we can still make! Care to PR this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I can try - at the very least, it would be a great opportunity for me to learn how to build and deploy Python 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @DHowett see here and let me know if anything's missing: | ||
def interactive_console(mainmodule=None, quiet=False, pythonstartup=False): | ||
Uh oh!
There was an error while loading.Please reload this page.