Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Docs: Move inline JavaScript to own file to reduce duplication#119541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 5 commits intopython:mainfromhugovk:rtd-switcher
May 27, 2024

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedMay 25, 2024•
edited by github-actionsbot
Loading

Follow on from#116966.

Move the language/version switcher JavaScript from thelayout.html template, which meant it was included in the header of every page, and into its own JavaScript file to reduce duplication.

This reduces the size of the entire docs HTML (Doc/build/html) from 69.7 MB to 68.2 MB.

cc@humitos

📚 Documentation preview 📚:https://cpython-previews--119541.org.readthedocs.build/

@hugovkhugovk added docsDocumentation in the Doc dir needs backport to 3.13bugs and security fixes labelsMay 25, 2024
Copy link
Contributor

@Wulian233Wulian233 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My PR added 3.14 in layout.htmlwhich conflicts with the change of this PR

Copy link
Contributor

@humitoshumitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR makes sense and looks good to me! 👍🏼

@hugovkhugovkenabled auto-merge (squash)May 27, 2024 14:34
@hugovk
Copy link
MemberAuthor

PR#119607 will fix the doctest.

@hugovkhugovk merged commiteea26c4 intopython:mainMay 27, 2024
25 checks passed
@hugovkhugovk deleted the rtd-switcher branchMay 27, 2024 18:04
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker eea26c4a731ff9547d48a6761b209fee3f2f84df 3.13

hugovk added a commit to hugovk/cpython that referenced this pull requestMay 27, 2024
…pythonGH-119541)(cherry picked from commiteea26c4)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-119630 is a backport of this pull request to the3.13 branch.

@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker eea26c4a731ff9547d48a6761b209fee3f2f84df 3.12

@hugovk
Copy link
MemberAuthor

I'll include this 3.12 backport in the#120348 backport.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Wulian233Wulian233Wulian233 left review comments

@humitoshumitoshumitos approved these changes

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip issueskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@humitos@Wulian233
[8]ページ先頭
©2009-2025 Movatter.jp