Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-69214: Fix fcntl.ioctl() request type#119498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:ioctl_long
May 24, 2024

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 24, 2024•
edited by bedevere-appbot
Loading

Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.
@vstinner
Copy link
MemberAuthor

cc@serhiy-storchaka

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

It could be better, because in POSIX its type isint, and on Linux we can make it stricter withbitwise=False , but this is good enough.

@vstinnervstinner merged commit92fab33 intopython:mainMay 24, 2024
41 checks passed
@vstinnervstinner deleted the ioctl_long branchMay 24, 2024 12:31
@miss-islington-app
Copy link

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.(cherry picked from commit92fab33)Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington-app
Copy link

Sorry,@vstinner, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 92fab3356f4c61d4c73606e4fae705c6d8f6213b 3.12

@bedevere-app
Copy link

GH-119504 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 24, 2024
@bedevere-app
Copy link

GH-119505 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 24, 2024
@vstinner
Copy link
MemberAuthor

Merged, thanks for the review.

vstinner added a commit to vstinner/cpython that referenced this pull requestMay 24, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.(cherry picked from commit92fab33)
vstinner added a commit that referenced this pull requestMay 24, 2024
gh-69214: Fix fcntl.ioctl() request type (#119498)Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.(cherry picked from commit92fab33)
vstinner added a commit that referenced this pull requestMay 24, 2024
gh-69214: Fix fcntl.ioctl() request type (GH-119498)Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.(cherry picked from commit92fab33)Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit to vstinner/cpython that referenced this pull requestJun 1, 2024
vstinner added a commit to vstinner/cpython that referenced this pull requestJun 1, 2024
…GH-119498) (python#119504)"This reverts commit0bab0b3.The change modified how negative values, like termios.TIOCSWINSZ, wastreated and is actually backward incompatible.
vstinner added a commit to vstinner/cpython that referenced this pull requestJun 1, 2024
…#119498) (python#119505)"This reverts commit078da88.The change modified how negative values, like termios.TIOCSWINSZ, wastreated and is actually backward incompatible.
vstinner added a commit that referenced this pull requestJun 1, 2024
…) (#1… (#119905)Revert "[3.12]gh-69214: Fix fcntl.ioctl() request type (#119498) (#119505)"This reverts commit078da88.The change modified how negative values, like termios.TIOCSWINSZ, wastreated and is actually backward incompatible.
vstinner added a commit that referenced this pull requestJun 1, 2024
…9498) (… (#119906)Revert "[3.13]gh-69214: Fix fcntl.ioctl() request type (GH-119498) (#119504)"This reverts commit0bab0b3.The change modified how negative values, like termios.TIOCSWINSZ, wastreated and is actually backward incompatible.
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the requestparameter of fcntl.ioctl() to support requests larger than UINT_MAX.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

@vstinnervstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vstinner@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp