Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-119467: Fix Py_buffer.format type and correct documentation typo#119475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedMay 23, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
This commit addresses the inconsistency between the Py_buffer.format declaration and its documentation as reported in issuepython#119467. The documentation previously stated `const char *` for the format field, which has been corrected to `char *` to match the actual code declaration. Additionally, a spelling mistake in the documentation has been corrected to enhance clarity and accuracy.References:- Issue:python#119467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@adiaholic , thank you for your first contribution.
These details help raise confidence in the quality of the docs.
I will ask if@encukou can merge this because he is more familiar with the C API and he has the merge authority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Thanks@adiaholic for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…typo (pythonGH-119475)(cherry picked from commit3b26cd8)Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
…typo (pythonGH-119475)(cherry picked from commit3b26cd8)Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
GH-119602 is a backport of this pull request to the3.13 branch. |
GH-119603 is a backport of this pull request to the3.12 branch. |
Uh oh!
There was an error while loading.Please reload this page.
This commit addresses the inconsistency between the Py_buffer.format declaration and its documentation as reported in issue#119467.
The documentation previously stated
const char *for the format field, which has been corrected tochar *to match the actual code declaration. Additionally, a spelling mistake in the documentation has been corrected to enhance clarity and accuracy.📚 Documentation preview 📚:https://cpython-previews--119475.org.readthedocs.build/