NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.13] gh-119247: Add macros to use PySequence_Fast safely in free-threaded build (GH-119315)#119419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-baf347d-3.13

May 22, 2024

Merged

[3.13] gh-119247: Add macros to use PySequence_Fast safely in free-threaded build (GH-119315)#119419

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-baf347d-3.13

May 22, 2024

Conversation

Copy link

Contributor

miss-islington commentedMay 22, 2024•
edited by bedevere-appbot
Loading

AddPy_BEGIN_CRITICAL_SECTION_SEQUENCE_FAST and
Py_END_CRITICAL_SECTION_SEQUENCE_FAST macros and updatestr.join to use
them. Also add a regression test that would crash reliably without this
patch.
(cherry picked from commitbaf347d)

Co-authored-by: Josh {*()} Rosenberg26495692+MojoVampire@users.noreply.github.com

Issue:PySequence_Fast needs new macros to be safe in a nogil world #119247

pythongh-119247: Add macros to use PySequence_Fast safely in free-thr…

5860dc7

…eaded build (pythonGH-119315)Add `Py_BEGIN_CRITICAL_SECTION_SEQUENCE_FAST` and`Py_END_CRITICAL_SECTION_SEQUENCE_FAST` macros and update `str.join` to usethem. Also add a regression test that would crash reliably without thispatch.(cherry picked from commitbaf347d)Co-authored-by: Josh {*()} Rosenberg <26495692+MojoVampire@users.noreply.github.com>