Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119180: Update the magic number#119397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 2 commits intopython:mainfromJelleZijlstra:pep649-magic
May 25, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMay 22, 2024•
edited by bedevere-appbot
Loading

PR#119321 added a comment about the magic number bump
but did not actually apply the new magic number.

Also, updatePC/launcher.c.

@Eclips4
Copy link
Member

I've probably found a typo:

# Python 3.14a1 3600 (Add LOAD_COMMON_CONSTANT)

Since we are ata0 now, there's should be3.14a0, isn't it?
If so, I think we can address that in this PR :)

@JelleZijlstra
Copy link
MemberAuthor

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

@Eclips4
Copy link
Member

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

I was confused by an older entries where'sa0 is used:

# Python 3.9a0 3420 (add LOAD_ASSERTION_ERROR #34880)
# Python 3.9a0 3421 (simplified bytecode for with blocks #32949)
# Python 3.9a0 3422 (remove BEGIN_FINALLY, END_FINALLY, CALL_FINALLY, POP_FINALLY bytecodes #33387)

It seems that the policy has changed since then?

@JelleZijlstraJelleZijlstra merged commit84be524 intopython:mainMay 25, 2024
36 checks passed
@JelleZijlstraJelleZijlstra deleted the pep649-magic branchMay 25, 2024 00:32
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
PRpython#119321 added a comment about the magic number bumpbut did not actually apply the new magic number.
@JelleZijlstraJelleZijlstra restored the pep649-magic branchSeptember 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvAwaiting requested review from ambv

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JelleZijlstra@Eclips4
[8]ページ先頭
©2009-2025 Movatter.jp