Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.12] gh-118507 : Fixntpath.isfile for pipes.#119381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 5 commits intopython:3.12fromnineteendo:backport-b641825-3.12
May 22, 2024

Conversation

@nineteendo
Copy link
Contributor

@nineteendonineteendo commentedMay 22, 2024•
edited by bedevere-appbot
Loading

@nineteendo
Copy link
ContributorAuthor

nineteendo commentedMay 22, 2024•
edited
Loading

I think I didn't include unrelated changes. Is it fine to use the C version forntpath.isjunction() andntpath.lexists()? (We did so for 3.13 too) Otherwise I'll revert that change.

@nineteendonineteendo marked this pull request as ready for reviewMay 22, 2024 07:23
@nineteendonineteendo changed the title[3.12] gh-118507 : Refactornt._path_is* (GH-118755)[3.12] gh-118507 : Refactornt._path_is* to improve applicability for other cases (GH-118755)May 22, 2024
@zooba
Copy link
Member

Is it fine to use the C version forntpath.isjunction() andntpath.lexists()?

Let's revert those, just to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident.

@zoobazooba self-assigned thisMay 22, 2024
@nineteendo
Copy link
ContributorAuthor

nineteendo commentedMay 22, 2024•
edited
Loading

Done, I also removed the C implementation for these functions to not give anyone ideas...
I can make a draft pull request afterwards to make it clear the issue can't be closed yet.

zooba reacted with thumbs up emoji

@nineteendonineteendo changed the title[3.12] gh-118507 : Refactornt._path_is* to improve applicability for other cases (GH-118755)[3.12] gh-118507 : Fixntpath.isfile for pipes.May 22, 2024
@zoobazooba merged commit874a4f7 intopython:3.12May 22, 2024
@zooba
Copy link
Member

A draft pull request is a good idea.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@zoobazooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nineteendo@zooba
[8]ページ先頭
©2009-2025 Movatter.jp