Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-74929: PEP 667 C API documentation#119379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ncoghlan merged 7 commits intopython:mainfromncoghlan:gh-74929-pep-667-c-api-docs
Jun 1, 2024

Conversation

ncoghlan
Copy link
Contributor

@ncoghlanncoghlan commentedMay 22, 2024•
edited by github-actionsbot
Loading

@ncoghlanncoghlan added docsDocumentation in the Doc dir skip news 3.13bugs and security fixes 3.14bugs and security fixes needs backport to 3.13bugs and security fixes labelsMay 22, 2024
@ncoghlanncoghlan self-assigned thisMay 22, 2024
@ncoghlan
Copy link
ContributorAuthor

ncoghlan commentedMay 22, 2024•
edited
Loading

Searching for the C APIs updated by the PEP identified some outdated mentions in comments, hence the changes to a few Python and C files.

@@ -1888,8 +1888,7 @@ frame_get_var(_PyInterpreterFrame *frame, PyCodeObject *co, int i,
}
// (likely) Otherwise it is an arg (kind & CO_FAST_LOCAL),
// with the initial value set when the frame was created...
// (unlikely) ...or it was set to some initial value by
// an earlier call to PyFrame_LocalsToFast().
// (unlikely) ...or it was set via the f_locals proxy.
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm pretty sure this "set externally" loophole still exists, it's just accessed slightly differently now.

@ncoghlan
Copy link
ContributorAuthor

ncoghlan commentedMay 27, 2024•
edited
Loading

I've kept the reference out to the PEP for details of the C API changes, so I'll submit a PR there that skips listingPyFrame_GetLocals() as a new API (it was already added back in Python 3.11, so it isn't being added by the PEP anymore)

PR posted:python/peps#3793

@ncoghlan
Copy link
ContributorAuthor

I'll leave this another couple of days to give@markshannon and@gaogaotiantian a further chance to comment, but I'll make sure this and the related PR to the PEP are merged before beta2 next week.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small nitpicks for consistency.

ncoghlanand others added2 commitsMay 31, 2024 20:43
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@miss-islington-app
Copy link

Thanks@ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 1, 2024
* Add docs for new APIs* Add soft-deprecation notices* Add What's New porting entries* Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead* Other related cleanups found when looking for refs to the deprecated APIs(cherry picked from commit3859e09)Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
@bedevere-app
Copy link

GH-119892 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJun 1, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull requestJun 5, 2024
* Add docs for new APIs* Add soft-deprecation notices* Add What's New porting entries* Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead* Other related cleanups found when looking for refs to the deprecated APIs
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
* Add docs for new APIs* Add soft-deprecation notices* Add What's New porting entries* Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead* Other related cleanups found when looking for refs to the deprecated APIs
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
* Add docs for new APIs* Add soft-deprecation notices* Add What's New porting entries* Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead* Other related cleanups found when looking for refs to the deprecated APIs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou left review comments

@picnixzpicnixzpicnixz left review comments

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@ncoghlanncoghlan

Labels
3.13bugs and security fixes3.14bugs and security fixesdocsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ncoghlan@encukou@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp