Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119357: Increase test coverage for keymap in _pyrepl#119358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 4 commits intopython:mainfromeugenetriguba:gh-119357
May 22, 2024

Conversation

eugenetriguba
Copy link
Contributor

@eugenetrigubaeugenetriguba commentedMay 21, 2024•
edited by bedevere-appbot
Loading

This PR adds a few test cases to the keymap module tests to increase the coverage.

Lib/_pyrepl/keymap.py                 79      0     48      0   100%

@@ -30,7 +30,7 @@
# types
Command = commands.Command
if False:
from .types import Callback, SimpleContextManager, KeySpec, CommandName
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

note: these two aren't used

@eugenetriguba
Copy link
ContributorAuthor

I'd think this PR can skip news

@ambvambv added skip news topic-replRelated to the interactive shell labelsMay 21, 2024
@eugenetriguba
Copy link
ContributorAuthor

eugenetriguba commentedMay 21, 2024•
edited
Loading

@ambv beat me to it, thanks for the fix 🙂 I'll update the issue to more clearly encompass all of PyREPL instead of just the keymap module. Thanks for the feedback, let me know if you had any other requested changes!

@ambvambv merged commit73ab83b intopython:mainMay 22, 2024
@lysnikolaoulysnikolaou added the needs backport to 3.13bugs and security fixes labelMay 22, 2024
@miss-islington-app
Copy link

Thanks@eugenetriguba for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@eugenetriguba and@ambv, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 73ab83b27f105a4509046ce26e35f20d66625195 3.13

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull requestMay 22, 2024
…ythonGH-119358)(cherry picked from commit73ab83b)Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-119414 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 22, 2024
ambv added a commit that referenced this pull requestMay 22, 2024
…9358) (#119414)(cherry picked from commit73ab83b)Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvambv left review comments

Assignees

@ambvambv

Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@eugenetriguba@ambv@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp