Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118911: Trailing whitespace in a block shouldn't prevent the user from terminating the code block#119355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 8 commits intopython:mainfromaelsayed95:fix_issue_118911
May 22, 2024

Conversation

aelsayed95
Copy link
Contributor

@aelsayed95aelsayed95 commentedMay 21, 2024•
edited by bedevere-appbot
Loading

Issue described in#118911

Fix includes:

  1. If the user hits enter twice, they are able to exit out of the block, even if there's trailing whitespace.
  2. Trim trailing whitespace in theHistoricalReader to match IPython's behavior

@ghost
Copy link

ghost commentedMay 21, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@aelsayed95
Copy link
ContributorAuthor

One issue discovered while testing this (exists on main too):

Within a code block, if the user hits enter twice to add new lines, the first line matches the previous line's indentation while the next one doesn't.
This doesn't match IPython's behaviour.

ambv reacted with thumbs up emoji

@aelsayed95
Copy link
ContributorAuthor

Added#119356

@lysnikolaoulysnikolaou added the needs backport to 3.13bugs and security fixes labelMay 21, 2024
Copy link
Member

@savannahostrowskisavannahostrowski left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! I tested this on Fedora (via Devcontainer) and it looks like this now works as described.

Copy link
Contributor

@ambvambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good.

I merged new changes inmain into your PR since there were conflicts, and reworded the blurb per my suggestion.

@ambvambv merged commit5091c44 intopython:mainMay 22, 2024
@miss-islington-app
Copy link

Thanks@aelsayed95 for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@aelsayed95 and@ambv, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 5091c4400c9ea2a2d1e4d89a28c9d0de2651fa6d 3.13

@ambv
Copy link
Contributor

Thanks, Aya! ✨ 🍰 ✨

@ambv
Copy link
Contributor

The backport depends onGH-119362. I'll deal with that tomorrow.

@lysnikolaou
Copy link
Member

Thanks,@aelsayed95! I've merged#119362. I'll open a backport PR now.

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull requestMay 22, 2024
…ent the user from terminating the code block (pythonGH-119355)(cherry picked from commit5091c44)Co-authored-by: Aya Elsayed <ayah.ehab11@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-119404 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 22, 2024
lysnikolaou added a commit that referenced this pull requestMay 23, 2024
…e user from terminating the code block (GH-119355) (#119404)(cherry picked from commit5091c44)Co-authored-by: Aya Elsayed <ayah.ehab11@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
… user from terminating the code block (python#119355)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@savannahostrowskisavannahostrowskisavannahostrowski left review comments

@ambvambvambv approved these changes

Assignees

@ambvambv

Labels
topic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aelsayed95@ambv@lysnikolaou@savannahostrowski
[8]ページ先頭
©2009-2025 Movatter.jp