Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111201: auto-indentation in _pyrepl#119348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 2 commits intopython:mainfromwiggin15:pyrepl-auto-indent
May 22, 2024

Conversation

wiggin15
Copy link
Contributor

@wiggin15wiggin15 commentedMay 21, 2024•
edited by bedevere-appbot
Loading

Auto-indent blocks in new _pyrepl when the user presses after a line that should start a new block. By default, indent by 4 spaces, but keep the user indentation if the user changes it.

Ideas for future improvement (not included in this PR):

  • Add configuration to specify default number of spaces
  • Better parsing of latest line to support auto indentation after lines like this:if foo: # bar (currently it will not auto-indent after this line)

@bedevere-appbedevere-appbot mentioned this pull requestMay 21, 2024
7 tasks
@ambvambv added skip news topic-replRelated to the interactive shell labelsMay 21, 2024
@ambvambvforce-pushed thepyrepl-auto-indent branch from5090e05 toac4a8a5CompareMay 22, 2024 02:51
@wiggin15
Copy link
ContributorAuthor

Hi@ambv , I see the commit authorship changed for the first commit 😬

@ambvambv merged commitcd516cd intopython:mainMay 22, 2024
@ambv
Copy link
Contributor

We squash all commits so this isn't important. As you can see incd516cd the merged commit is attributed to you.

@ambv
Copy link
Contributor

Thanks for your contribution, Arnon!

@lysnikolaoulysnikolaou added the needs backport to 3.13bugs and security fixes labelMay 22, 2024
@miss-islington-app
Copy link

Thanks@wiggin15 for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@wiggin15 and@ambv, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker cd516cd1f5e94dba887353f421513fd172efadf3 3.13

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull requestMay 22, 2024
(cherry picked from commitcd516cd)Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull requestMay 22, 2024
(cherry picked from commitcd516cd)Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-119427 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 22, 2024
ambv added a commit that referenced this pull requestMay 22, 2024
(cherry picked from commitcd516cd)Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@wiggin15wiggin15 deleted the pyrepl-auto-indent branchMay 27, 2024 14:06
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@ambvambv

Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@wiggin15@ambv@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp